Skip to content

Api v2 create global task #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 141 commits into
base: develop
Choose a base branch
from
Open

Api v2 create global task #969

wants to merge 141 commits into from

Conversation

@c8y3
Copy link
Contributor

@c8y3 c8y3 commented Nov 7, 2025 •
edited
Loading

Implementation of endpoint POST /api/v2/global-tasks

  • Deprecated POST /global/tasks/add
  • Added import constraint: Do not import the persistence layer from the models
  • Removed some import app
  • some code factorization in the persistence layer
    Goes with documentation PR#94

Elise17 added 30 commits October 8, 2025 14:04
@Elise17
Started implementation of POST /api/v2/alerts-filters
9a33abf
@Elise17
Fixed analysis check
b7088fd
@Elise17
Added function _load
103ed2c
@Elise17
Deprecated endpoint POST /filters/add in favor of POST /api/v2/alerts…
82bfec6 
…-filters
@Elise17
Added test create alert when filter data is missing
5b1290e
@Elise17
Added test test_create_alert_filter_should_return_filter_type
ea45b99
@Elise17
Added test_create_alert_filter_should_return_filter_name
4c5ddd6
@Elise17
Added test_create_alert_filter_should_return_in_filter_data_alert_title
0a0f63d
@Elise17
Started implementation of GET /api/v2/alerts-filters/{identifier}
af0bf2b
@Elise17
Fixed check analysis
0c911fe
@Elise17
Fixed importation problem
8559ad7
@Elise17
Fixed static analysis
7440b09
@Elise17
Removed user in test
0690eb0
@Elise17
Added test_get_alert_filter_should_return_filter_name
1129b73
@Elise17
Deprecated endpoint GET /filters/{identifier}
97a89e5
@Elise17
Added test_get_alert_filter_should_return_404
622b46a
@Elise17
Added test_get_alert_filter_should_return_404_when_user_has_not_creat…
9a1fffd 
…ed_alert_filter
@Elise17
Fixed static analysis
e4b4998
@Elise17
Started implementation of PUT /api/v2/alerts-filters/{identifier}
69e38c8
@Elise17
Fixed static analysis
ec809ef
@Elise17
Added test_update_alert_filter_should_return_filter_name
f438d3b
@Elise17
Added test_update_alert_filter_should_return_filter_description
930e94c
@Elise17
Added test_update_alert_filter_should_return_filter_type
120bed5
@Elise17
Added test_update_alert_filter_should_return_filter_data_alert_title
48c0957
@Elise17
Added test_update_alert_filter_should_return_404_when_alert_filter_is…
657d441 
…_not_found
@Elise17
Removed identifietr in test_update_alert_filter_should_return_404_whe…
1008f29 
…n_alert_filter_is_not_found
@Elise17
Deprecated endpoint POST /filters/update/{identifier}
78234ef
@Elise17
Started implmentation of endpoint DELETE /api/v2/alerts-filters/{iden…
eb541cb 
…tifier}
@Elise17
Added test_delete_alert_filter_should_return_404_when_alert_not_found
745739c
@Elise17
test_get_alert_filter_should_return_404_after_delete_alert_filter
74bf4ea
c8y3 added 23 commits November 5, 2025 12:25
@c8y3
Factored code somewhat
dcc4830
@c8y3
Removed cycle
76acb33
@c8y3
Use method from the business layer
5244279
@c8y3
Use method from the API layer
0f4319e
@c8y3
Fixed incorrect retrieval of identifier
8f3bf8e
@c8y3
Import db directly from app.db rather than from app
88d09a3
@c8y3
Deprecated GET /manage/customers/list
ebe8870
@c8y3
Fixed deepsource warning
08db0cd
@c8y3
Fixed missing parameters
be022b8
@c8y3
Fixed bug when checking for permission
6fe4364
@c8y3
Started implementation of POST /api/v2/global-tasks
216b57c
@c8y3
Fixed ruff warnings
87b0949
@c8y3
Factored code to create an object in database
70f262c
@c8y3
Removed unnecessary return values
005ab91
@c8y3
Generalized import-linter constraint somewhat
d7393b9
@c8y3
Calling conventions
1862bb7
@c8y3
Added a FIXME
5544829
@c8y3
Removed unnecessary return
8fa3305
@c8y3
Added import constraint: Do not import the persistence layer from the…
c69dcf5 
… models
@c8y3
Deprecated POST /global/tasks/add
1daa99c
@c8y3
Removed an import app
7a1b747
@c8y3
Removed an import app
c345e41
@c8y3
Removed an import app
5c474c1
@c8y3 c8y3 requested a review from whikernel November 7, 2025 14:06
@c8y3 c8y3 self-assigned this Nov 7, 2025
@c8y3 c8y3 added the enhancement New feature or request label Nov 7, 2025
@c8y3 c8y3 assigned whikernel and unassigned c8y3 Nov 7, 2025
@c8y3 c8y3 linked an issue Nov 7, 2025 that may be closed by this pull request
API v2 create global task #968
Open
10 tasks
@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • api_*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch api_v2_create_global_task

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whikernel whikernel Awaiting requested review from whikernel

Assignees

@whikernel whikernel

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API v2 create global task

4 participants

@c8y3 @whikernel @Elise17