Added ruff rule W391

c8y3 · c8y3 · commit e25ba9849024 · 2025-10-29T15:42:23.000+01:00
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.ruff.lint]
 preview = true
-select = ["ARG003", "ARG005", "B00", "E101", "E20", "E225", "E23", "E24", "E3", "E4", "E7", "E9", "F", "FURB142", "FURB145", "FURB148", "PLR0402", "RET506", "RUF029", "RUF100", "TID252", "UP032", "W29"]
+select = ["ARG003", "ARG005", "B00", "E101", "E20", "E225", "E23", "E24", "E3", "E4", "E7", "E9", "F", "FURB142", "FURB145", "FURB148", "PLR0402", "RET506", "RUF029", "RUF100", "TID252", "UP032", "W29", "W391"]
 ignore = ["E402", "E711", "E712", "E721", "E722"]
 
 [tool.vulture]
diff --git a/source/app/alembic/versions/10a7616f3cc7_add_module_types.py b/source/app/alembic/versions/10a7616f3cc7_add_module_types.py
@@ -42,4 +42,3 @@ def upgrade():
 
 def downgrade():
     pass
-
diff --git a/source/app/alembic/versions/ad4e0cd17597_add_ioctype_validation.py b/source/app/alembic/versions/ad4e0cd17597_add_ioctype_validation.py
@@ -93,4 +93,3 @@ def upgrade():
 def downgrade():
     op.drop_column('ioc_type', 'type_validation_regex')
     op.drop_column('ioc_type', 'type_validation_expect')
-
diff --git a/source/app/alembic/versions/cd519d2d24df_password_policy_edition.py b/source/app/alembic/versions/cd519d2d24df_password_policy_edition.py
@@ -57,4 +57,3 @@ def upgrade():
 
 def downgrade():
     pass
-
diff --git a/source/app/alembic/versions/d5a720d1b99b_add_alerts_indexes.py b/source/app/alembic/versions/d5a720d1b99b_add_alerts_indexes.py
@@ -61,4 +61,3 @@ def downgrade():
 
     # Drop AlertSimilarity table
     op.drop_table('alert_similarity')
-
diff --git a/source/app/blueprints/graphql/sliced_result.py b/source/app/blueprints/graphql/sliced_result.py
@@ -29,4 +29,3 @@ def __getitem__(self, index: slice) -> any:
 
     def __len__(self) -> int:
         return self._total
-
diff --git a/source/app/blueprints/rest/parsing.py b/source/app/blueprints/rest/parsing.py
@@ -51,4 +51,3 @@ def parse_pagination_parameters(request: Request, default_order_by=None, default
     direction = arguments.get('sort_dir', default_direction, type=str)
 
     return PaginationParameters(page, per_page, order_by, direction)
-
diff --git a/source/app/business/customers_contacts.py b/source/app/business/customers_contacts.py
@@ -26,5 +26,3 @@ def customers_contacts_get(identifier) -> Contact:
     if not contact:
         raise ObjectNotFoundError()
     return contact
-
-
diff --git a/source/app/datamgmt/dashboard/dashboard_db.py b/source/app/datamgmt/dashboard/dashboard_db.py
@@ -181,5 +181,3 @@ def list_user_cases(user_identifier, show_all=False):
         Cases.owner_id == user_identifier,
         Cases.close_date == None
     ).all()
-
-
diff --git a/source/app/datamgmt/datastore/datastore_db.py b/source/app/datamgmt/datastore/datastore_db.py
@@ -559,4 +559,3 @@ def datastore_filter_tree(filter_d, caseid):
             datastore_iter_tree(dpath_parent_id, path_node, droot_children)
 
     return path_tree, 'Success'
-
diff --git a/source/app/datamgmt/manage/manage_tags_db.py b/source/app/datamgmt/manage/manage_tags_db.py
@@ -89,4 +89,3 @@ def add_db_tag(tag_title, tag_namespace=None):
         raise e
 
     return tag
-
diff --git a/source/app/iris_engine/updater/__init__.py b/source/app/iris_engine/updater/__init__.py
@@ -1,2 +1 @@
 
-
diff --git a/source/app/iris_engine/utils/__init__.py b/source/app/iris_engine/utils/__init__.py
@@ -15,4 +15,3 @@
 #  You should have received a copy of the GNU Lesser General Public License
 #  along with this program; if not, write to the Free Software Foundation,
 #  Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
-
diff --git a/source/run.py b/source/run.py
@@ -28,4 +28,3 @@
 
 if __name__ == "__main__":
     socket_io.run(app, host='127.0.0.1', port=8000, debug=True)
-
diff --git a/tests/tests_rest_notes.py b/tests/tests_rest_notes.py
@@ -263,4 +263,3 @@ def test_socket_io_join_notes_overview_should_not_fail(self):
             socket_io_client.emit('join-notes-overview', f'case-{case_identifier}-notes')
             message = socket_io_client.receive()
             self.assertEqual('administrator', message['user'])
-

Original file line number	Diff line number	Diff line change
`@@ -42,4 +42,3 @@ def upgrade():`
`42`	`42`
`43`	`43`	`def downgrade():`
`44`	`44`	`pass`
`45`		`-`
Original file line number	Diff line number	Diff line change
`@@ -57,4 +57,3 @@ def upgrade():`
`57`	`57`
`58`	`58`	`def downgrade():`
`59`	`59`	`pass`
`60`		`-`
Original file line number	Diff line number	Diff line change
`@@ -61,4 +61,3 @@ def downgrade():`
`61`	`61`
`62`	`62`	`# Drop AlertSimilarity table`
`63`	`63`	`op.drop_table('alert_similarity')`
`64`		`-`
Original file line number	Diff line number	Diff line change
`@@ -29,4 +29,3 @@ def __getitem__(self, index: slice) -> any:`
`29`	`29`
`30`	`30`	`def __len__(self) -> int:`
`31`	`31`	`return self._total`
`32`		`-`
Original file line number	Diff line number	Diff line change
`@@ -51,4 +51,3 @@ def parse_pagination_parameters(request: Request, default_order_by=None, default`
`51`	`51`	`direction = arguments.get('sort_dir', default_direction, type=str)`
`52`	`52`
`53`	`53`	`return PaginationParameters(page, per_page, order_by, direction)`
`54`		`-`
Original file line number	Diff line number	Diff line change
`@@ -559,4 +559,3 @@ def datastore_filter_tree(filter_d, caseid):`
`559`	`559`	`datastore_iter_tree(dpath_parent_id, path_node, droot_children)`
`560`	`560`
`561`	`561`	`return path_tree, 'Success'`
`562`		`-`