Fixed import constraint

Author: c8y3

source/app/blueprints/rest/manage/manage_customers_routes.py

@@ -28,6 +28,7 @@
 from app.business.customers import customers_get
 from app.business.customers_contacts import customers_contacts_get
 from app.models.errors import ObjectNotFoundError
+from app.models.errors import ElementInUseError
 from app.datamgmt.client.client_db import create_customer
 from app.datamgmt.client.client_db import create_contact
 from app.datamgmt.client.client_db import delete_client
@@ -40,7 +41,6 @@
 from app.datamgmt.client.client_db import get_client_contact
 from app.datamgmt.client.client_db import update_client
 from app.datamgmt.client.client_db import update_contact
-from app.datamgmt.exceptions.ElementExceptions import ElementInUseException
 from app.datamgmt.manage.manage_users_db import add_user_to_customer
 from app.iris_engine.utils.tracker import track_activity
 from app.models.authorization import Permissions
@@ -290,7 +290,7 @@ def delete_customers(client_id):
     except ObjectNotFoundError:
         return response_error('Invalid Customer ID')
 
-    except ElementInUseException:
+    except ElementInUseError:
         return response_error('Cannot delete a referenced customer')
 
     except Exception:
@@ -313,7 +313,7 @@ def delete_contact_route(client_id, contact_id):
     except ObjectNotFoundError:
         return response_error('Invalid contact ID')
 
-    except ElementInUseException:
+    except ElementInUseError:
         return response_error('Cannot delete a referenced contact')
 
     except Exception:

source/app/blueprints/rest/v2/manage_routes/customers.py

@@ -26,10 +26,10 @@
 from app.blueprints.rest.endpoints import response_api_not_found
 from app.blueprints.rest.endpoints import response_api_deleted
 from app.blueprints.access_controls import ac_api_requires
-from app.datamgmt.exceptions.ElementExceptions import ElementInUseException
 from app.models.authorization import Permissions
 from app.schema.marshables import CustomerSchema
 from app.models.errors import ObjectNotFoundError
+from app.models.errors import ElementInUseError
 from app.business.customers import customers_create_with_user
 from app.business.customers import customers_get
 from app.business.customers import customers_update
@@ -82,8 +82,8 @@ def delete(self, identifier):
 
         except ObjectNotFoundError:
             return response_api_not_found()
-        except ElementInUseException:
-            return response_api_error('Cannot delete a referenced customer')
+        except ElementInUseError as e:
+            return response_api_error(e.get_message())
 
 
 customers_blueprint = Blueprint('customers_rest_v2', __name__, url_prefix='/customers')

source/app/datamgmt/client/client_db.py

@@ -23,7 +23,7 @@
 from typing import Optional
 
 from app import db
-from app.datamgmt.exceptions.ElementExceptions import ElementInUseException
+from app.models.errors import ElementInUseError
 from app.models.cases import Cases
 from app.models.models import Client
 from app.models.models import Contact
@@ -143,7 +143,7 @@ def delete_contact(contact: Contact):
         db.session.commit()
 
     except Exception:
-        raise ElementInUseException('A currently referenced contact cannot be deleted')
+        raise ElementInUseError('A currently referenced contact cannot be deleted')
 
 
 def update_client(schema, customer: Client, data):
@@ -168,7 +168,7 @@ def delete_client(customer: Client) -> None:
         db.session.delete(customer)
         db.session.commit()
     except Exception:
-        raise ElementInUseException('A currently referenced customer cannot be deleted')
+        raise ElementInUseError('Cannot delete a referenced customer')
 
 
 def get_case_client(case_id: int) -> Client:

source/app/datamgmt/exceptions/ElementExceptions.py

@@ -41,7 +41,11 @@ def __init__(self):
 class UnhandledBusinessError(BusinessProcessingError):
 
     def __init__(self, message, data=None):
-        self._message = message
-        self._data = data
+        super().__init__(message, data)
         logger.exception(message)
         logger.exception(data)
+
+
+class ElementInUseError(BusinessProcessingError):
+
+    pass