Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Api to make deployment template override for env of Devtron application #5091

Open
2 tasks done
ajaydevtron opened this issue May 9, 2024 · 0 comments · May be fixed by #5096
Open
2 tasks done

Feature: Api to make deployment template override for env of Devtron application #5091

ajaydevtron opened this issue May 9, 2024 · 0 comments · May be fixed by #5096
Assignees
Labels
enhancement New feature or request ICA-AUG24 Issue Cleanup Activity Aug 2024

Comments

@ajaydevtron
Copy link
Contributor

ajaydevtron commented May 9, 2024

🔖 Feature description

We need to update the chart version of application from 3.7 to 4.18 and used the below api .

curl -sX PATCH 'https://cd.devtron.com/orchestrator/app/env/patch' \
  -H 'token: xxxxx' \
  --data-raw "{\"envId\":env_id,\"targetChartRefId\":36,\"appId\":app_id}"

But this api only update the chart version if env have overridden otherwise it through below error .

{"level":"error","ts":1715257109.8727689,"caller":"configure/DeploymentPipelineRestHandler.go:546","msg":"env properties not found, ChangeChartRef","err":null,"payload":{"appId":4136,"envId":41,"targetChartRefId":36},"stacktrace":"github.com/devtron-labs/devtron/api/restHandler/app/pipeline/configure.(*PipelineConfigRestHandlerImpl).ChangeChartRef\n\t/go/src/github.com/devtron-labs/devtron/api/restHandler/app/pipeline/configure/DeploymentPipelineRestHandler.go:546\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2122\ngo.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux.traceware.ServeHTTP\n\t/go/src/github.com/devtron-labs/devtron/vendor/go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux/mux.go:179\ngithub.com/devtron-labs/common-lib/middlewares.Recovery.func1\n\t/go/src/github.com/devtron-labs/devtron/vendor/github.com/devtron-labs/common-lib/middlewares/recovery.go:26\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2122\ngithub.com/devtron-labs/devtron/internal/middleware.PrometheusMiddleware.func1\n\t/go/src/github.com/devtron-labs/devtron/internal/middleware/instrument.go:132\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2122\ngithub.com/devtron-labs/devtron/api/util.LoggingMiddlewareImpl.LoggingMiddleware.func1\n\t/go/src/github.com/devtron-labs/devtron/api/util/logger.go:68\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2122\ngithub.com/gorilla/mux.(*Router).ServeHTTP\n\t/go/src/github.com/devtron-labs/devtron/vendor/github.com/gorilla/mux/mux.go:210\ngithub.com/devtron-labs/authenticator/middleware.Authorizer.func1.1\n\t/go/src/github.com/devtron-labs/devtron/vendor/github.com/devtron-labs/authenticator/middleware/AuthMiddleware.go:92\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2122\nnet/http.serverHandler.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2936\nnet/http.(*conn).serve\n\t/usr/local/go/src/net/http/server.go:1995"}
So due to this we need a put api by which we can allow override using app id and env id and then we can hit the env patch api to update the chart version .

🎤 Pitch / Usecases

NA

🔄️ Alternative

NA

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

AB#9772

@ajaydevtron ajaydevtron added the enhancement New feature or request label May 9, 2024
@ajaydevtron ajaydevtron added the ICA-AUG24 Issue Cleanup Activity Aug 2024 label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ICA-AUG24 Issue Cleanup Activity Aug 2024
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants