Merge pull request #588 from merico-dev/unit-test-improvement

test: improve the naming of the directory used for unit testing

Author: daniel-hutao

internal/pkg/pluginmanager/downloader_test.go

@@ -12,7 +12,7 @@ func TestDownload(t *testing.T) {
 	os.Remove(filepath.Join(".", "argocdapp_0.0.1-rc1.so"))
 
 	c := NewDownloadClient()
-	err := c.download(".", "argocdapp_0.0.1-rc1.so", "0.0.1-rc1")
+	err := c.download(".", "argocdapp_0.0.1-rc1.so", "0.0.1-ut-do-not-delete")
 	if err != nil {
 		t.Fatal("downloaded error")
 	}
@@ -22,7 +22,7 @@ func TestDownload(t *testing.T) {
 
 func TestDownloadNotFound(t *testing.T) {
 	c := NewDownloadClient()
-	err := c.download(".", "doesntexist", "0.0.1")
+	err := c.download(".", "doesntexist", "0.0.1-ut-do-not-delete")
 	// Since the right granted to public users on aws does not include listing bucket
 	// AWS returns 403 instead of 404 when acquiring an object where bucket does not exist: there is no list right.
 	assert.Contains(t, err.Error(), "403")