Return an explicit error if getShardId is out of bounds (#160)

* Return an explicit error if getShardId is out of bounds

* Imports

* Include entity id in error

* >= 1

Author: ghostdogpr

.gitignore

@@ -22,3 +22,5 @@ package-lock.json
 node_modules/
 .DS_Store
 vuepress/docs/.vuepress/dist
+project/project/metals.sbt
+project/project/project/metals.sbt

entities/src/main/scala/com/devsisters/shardcake/Sharding.scala

@@ -2,7 +2,7 @@ package com.devsisters.shardcake
 
 import com.devsisters.shardcake.Messenger.MessengerTimeout
 import com.devsisters.shardcake.Sharding.{ EntityState, ShardingRegistrationEvent }
-import com.devsisters.shardcake.errors.{ EntityNotManagedByThisPod, PodUnavailable, SendTimeoutException }
+import com.devsisters.shardcake.errors._
 import com.devsisters.shardcake.interfaces.Pods.BinaryMessage
 import com.devsisters.shardcake.interfaces.{ Pods, Serialization, Storage }
 import com.devsisters.shardcake.internal.{ EntityManager, ReplyChannel, SendChannel }
@@ -406,7 +406,8 @@ class Sharding private (
                       }
           } yield ()
 
-        trySend
+        if (shardId >= 1 && shardId <= config.numberOfShards) trySend
+        else ZIO.fail(InvalidShardId(entityId, shardId))
       }
 
       private def sendStreamGeneric[Res](
@@ -438,7 +439,8 @@ class Sharding private (
                       }
           } yield ()
 
-        trySend
+        if (shardId >= 1 && shardId <= config.numberOfShards) trySend
+        else ZIO.fail(InvalidShardId(entityId, shardId))
       }
     }
 

entities/src/main/scala/com/devsisters/shardcake/errors/InvalidShardId.scala

@@ -0,0 +1,7 @@
+package com.devsisters.shardcake.errors
+
+/**
+ * Exception indicating that a shard id is invalid.
+ */
+case class InvalidShardId(entityId: String, shardId: Int)
+    extends Exception(s"Invalid shard id: $shardId for entity $entityId")