Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake got "Could not found Go" error #40

Open
psionic12 opened this issue Aug 8, 2017 · 5 comments
Open

cmake got "Could not found Go" error #40

psionic12 opened this issue Aug 8, 2017 · 5 comments

Comments

@psionic12
Copy link

here's the log:

~/source/libquic/build$ cmake ..
-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Setting build type to 'Debug' as none was specified.
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Found Protobuf: /usr/local/lib/libprotobuf.so (Required is at least version "3")
-- Found Perl: /usr/bin/perl (found version "5.22.1")
CMake Error at boringssl/CMakeLists.txt:26 (message):
Could not find Go

-- Configuring incomplete, errors occurred!
See also "/home/liuyafei/source/libquic/build/CMakeFiles/CMakeOutput.log".
See also "/home/liuyafei/source/libquic/build/CMakeFiles/CMakeError.log".

@psionic12
Copy link
Author

I'v found the solution in #8, sorry for creating this issue

@Inokinoki
Copy link

I've met the same error. The solution works.
But I'd like to know why we should have a Golang executable.
Thank you for your response!

@q191201771
Copy link

I've met the same error. The solution works.
But I'd like to know why we should have a Golang executable.
Thank you for your response!

with the same question, I try

# cd into libquic
$find . -name '*.go'

and find out that lots of test file belongs libquic/boringssl use golang.

./boringssl/crypto/cipher/test/make_legacy_aead_tests.go
./boringssl/crypto/err/err_data_generate.go
./boringssl/ssl/test/runner/alert.go
./boringssl/ssl/test/runner/chacha20_poly1305.go
./boringssl/ssl/test/runner/chacha20_poly1305_test.go
...
...

and look inside libquic/boringssl/CMakeLists.txt, it will run these test file which written by golang.

@TomMD
Copy link

TomMD commented Aug 17, 2020

So can we disable the tests to build without go?

@smaudet
Copy link

smaudet commented Oct 19, 2020

@TomMD Yeah this seems wrong...

There is a "hard" dependency on go but there is no reason for it actually, after you generate the err_data.c you can skip test compilation for boringssl and there's zero dep after that on go. Really those files should be committed, or better yet convert the go script to a c program, then there's no weird dependency.

The usage of go is google fan-boy-ism at best, excessive pandering at worst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants