Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fixup html file for new prefab features #17

Open
mmore500 opened this issue Jul 15, 2020 · 3 comments
Open

Add/fixup html file for new prefab features #17

mmore500 opened this issue Jul 15, 2020 · 3 comments

Comments

@mmore500
Copy link
Member

  • reorder javascript includes
  • add new javascript includes
  • update bootstrap version
  • add our custom CSS file
  • add a loading modal and prefab card into the starter code
@mmore500
Copy link
Member Author

also <meta name="viewport" content="width=device-width, initial=scale=1.0"> into the head

@kayakingCellist
Copy link

I added theses changes in a new branch, prefab-links. When I was looking for the link to update Bootstrap CSS, I found links to updated Popper and Bootstrap js files. (https://getbootstrap.com/docs/4.5/getting-started/introduction/)

Should we add these too?

<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/umd/popper.min.js" integrity="sha384-Q6E9RHvbIyZFJoft+2mJbHaEWldlvI9IOYy5n3zV9zzTtmI3UksdQRVvoxMfooAo" crossorigin="anonymous"></script>
<script src="https://stackpath.bootstrapcdn.com/bootstrap/4.5.0/js/bootstrap.min.js" integrity="sha384-OgVRvuATP1z7JjHLkuOU7Xw704+h835Lr+6QL9UvYjZE3Ipu6Tp75j7Bh/kR0JKI" crossorigin="anonymous"></script>

@kayakingCellist
Copy link

The prefab-links branch will fail until Empirical's prefab branch is merged into master because using prefab tools requires the directory source/prefab/*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants