Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s manifests are missing namespace #44

Open
LittleFox94 opened this issue Oct 13, 2020 · 1 comment
Open

K8s manifests are missing namespace #44

LittleFox94 opened this issue Oct 13, 2020 · 1 comment

Comments

@LittleFox94
Copy link

The manifests for ServiceAccount and Secret do not have a namespace defined, making the install instructions incomplete

Since the ClusterRoleBinding binds to the ServceAccount grafana-kubegraf in Namespace default, this namespace should be set in the ServiceAccount resource, probably the same for the Secret resource

My kubeconfig is set to use the kube-system namespace by default
@SergeiSporyshev
Copy link
Collaborator

Hi, @LittleFox94
Thanks for your issue
Will add it asap

SergeiSporyshev added a commit that referenced this issue Dec 16, 2020
@SergeiSporyshev
[issue #44] move secret and serviceaccout to kubegraf ns
e72b0a0
SergeiSporyshev added a commit that referenced this issue Dec 16, 2020
@SergeiSporyshev
[issue #44] add new instructions to readme
4c9760a
@SergeiSporyshev SergeiSporyshev mentioned this issue Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LittleFox94 @SergeiSporyshev