Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arm64 builds #2232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix arm64 builds #2232

wants to merge 1 commit into from

Conversation

Crypto89
Copy link

Move the TARGETPLATFORM before the FROM, otherwise it'll default to the build platform.

Fixes #2201

@Crypto89 Crypto89 requested review from ChristophShyper and a team as code owners June 28, 2024 15:00
@Crypto89
Copy link
Author

This doesn't really work as intended, it's probably better to drop the TARGETPLATFORM any only use buildx even when not xcompiling. This doesn't work in combination with buildx, see issue docker/buildx#510

@ChristophShyper
Copy link
Member

Hello. I'll have a look at it when I have the time.
Thanks for taking interest in this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophShyper ChristophShyper Awaiting requested review from ChristophShyper ChristophShyper is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-ot-latest not running on EC2 aarch64
2 participants
@Crypto89 @ChristophShyper