Skip to content

Commit f8fa50c

Browse files
committed
Issue 31
1 parent 69f51e9 commit f8fa50c

File tree

3 files changed

+15
-23
lines changed

3 files changed

+15
-23
lines changed

README.md

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Create React WP Theme <!-- omit in toc -->
22

3-
Oct. 12, 2019
3+
Nov. 23, 2019
44
<br />
5-
*UPDATED* to match [v3.2.0](https://github.com/facebook/create-react-app/releases/tag/v3.2.0) of [Create React App](https://create-react-app.dev/)
5+
[v3.2.0](https://github.com/facebook/create-react-app/releases/tag/v3.2.0) of [Create React App](https://create-react-app.dev/) is still the latest.
66

77
The intention of this project is to maintain a set of custom `react-scripts` that will allow you to
88
create React WordPress themes as easily as `create-react-app` allows other devs to create their apps.
@@ -19,6 +19,7 @@ Check it out:
1919
[Let's build a WordPress theme with React: Part 1 (Setup)](http://michaelsoriano.com/wordpress-theme-react-part-1-setup/)
2020

2121
## Readme Contents <!-- omit in toc -->
22+
2223
For more details check out the rest of this document.
2324

2425
- [Creating a New Theme](#creating-a-new-theme)
@@ -58,7 +59,7 @@ To create a WordPress theme using the `create-react-wptheme`, follow these steps
5859
- Write access for your web server is only needed during this setup step.
5960
- **You can revoke write access after the setup has completed.**
6061
- Interested (paranoid?) about what it's doing? Check out the file: `<your theme folder name>/index.php`
61-
- When that's done the theme tells you to `Please restart the Nodejs watcher now...`
62+
- When that's done you'll see: `Now, back in your command prompt, rerun the "start" script again...`
6263
- To do that, go back to your command prompt where you first ran `npm run start` and rerun that same command again.
6364
- In a few seconds you should see your browser load with the standard create-react-app page, but it's running as a WordPress theme!
6465

@@ -154,16 +155,17 @@ When that command finishes, your optimized files are located in a folder that ca
154155

155156
Here's an example showing which folder to deploy to your server:
156157

157-
- ...wp-content
158-
- themes
159-
- my-theme
160-
- my-theme `<- deploy this folder to your production server's themes folder`
161-
- react-src
162-
- !READY_TO_DEPLOY!.txt
158+
- ...wp-content
159+
- themes
160+
- my-theme
161+
- my-theme `<- deploy this folder to your production server's themes folder`
162+
- react-src
163+
- !READY_TO_DEPLOY!.txt
163164

164165
If you need to continue developing your theme, simply:
165-
- `cd react-src`
166-
- `npm run start`
166+
167+
- `cd react-src`
168+
- `npm run start`
167169

168170
And all your theme files will reappear.
169171

createReactWpTheme.js

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const _wpThemeVersion = packageJson.version;
5050
const _createReactAppVersion = _wpThemeVersion.split("-wp.")[0];
5151

5252
// Check these!!!!
53-
const _reactScriptsWpThemeVersion = "3.2.0-wp.1";
53+
const _reactScriptsWpThemeVersion = "3.2.0-wp.2";
5454
const _getScriptsPath = function() {
5555
return scriptsFromNpm();
5656
};
@@ -98,16 +98,6 @@ const scriptsFromGit = function() {
9898
};
9999
};
100100

101-
const scriptsFromFile = function() {
102-
let filePath = "file:E:\\WPDev\\github\\devloco\\create-react-wptheme-scripts\\packages\\react-scripts";
103-
console.log("SCRIPTS FROM FILE", filePath);
104-
//let filePath = "file:/mnt/e/WPDev/github/devloco/create-react-wptheme-scripts/packages/react-scripts";
105-
return {
106-
path: filePath,
107-
callback: function() {}
108-
};
109-
};
110-
111101
let projectName;
112102
const program = new commander.Command(packageJson.name)
113103
.version(packageJson.version)

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devloco/create-react-wptheme",
3-
"version": "3.2.0-wp.2",
3+
"version": "3.2.0-wp.3",
44
"description": "Create React WP themes with no build configuration.",
55
"main": "index.js",
66
"scripts": {

0 commit comments

Comments
 (0)