Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging sensitive data #32

Open
kevinfalting opened this issue Sep 27, 2022 · 1 comment
Open

logging sensitive data #32

kevinfalting opened this issue Sep 27, 2022 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@kevinfalting
Copy link
Collaborator

This is happening locally, don't know if it's also happening in prd, but we're logging the tokens for editing a post.

job-board-app-1  | 2022/09/27 14:07:07 main.go:108: server listening on port :8080
job-board-app-1  | [GIN] 2022/09/27 - 14:07:16 | 200 |    8.339653ms |      172.19.0.1 | GET      "/"
job-board-app-1  | [GIN] 2022/09/27 - 14:07:16 | 304 |    2.037051ms |      172.19.0.1 | GET      "/assets/css/app.css"
job-board-app-1  | [GIN] 2022/09/27 - 14:07:16 | 304 |    2.724662ms |      172.19.0.1 | GET      "/assets/svg/devict-logo.svg"
job-board-app-1  | [GIN] 2022/09/27 - 14:07:16 | 304 |    1.826482ms |      172.19.0.1 | GET      "/assets/svg/circuit-board.svg"
job-board-app-1  | [GIN] 2022/09/27 - 14:07:16 | 404 |       3.887µs |      172.19.0.1 | GET      "/favicon.ico"
job-board-app-1  | [GIN] 2022/09/27 - 14:07:19 | 200 |     2.62795ms |      172.19.0.1 | GET      "/new"
job-board-app-1  | [GIN] 2022/09/27 - 14:08:01 | 302 |  1.061981724s |      172.19.0.1 | POST     "/jobs"
job-board-app-1  | [GIN] 2022/09/27 - 14:08:01 | 200 |      4.1646ms |      172.19.0.1 | GET      "/"
job-board-app-1  | [GIN] 2022/09/27 - 14:09:27 | 200 |    5.221391ms |      172.19.0.1 | GET      "/jobs/54/edit?token=tvtxz2yUaSZsK4ewEuRR1wtOlGs%3D"
job-board-app-1  | [GIN] 2022/09/27 - 14:10:01 | 302 |    2.525355ms |      172.19.0.1 | POST     "/jobs/54?token=tvtxz2yUaSZsK4ewEuRR1wtOlGs%3d"
job-board-app-1  | [GIN] 2022/09/27 - 14:10:01 | 200 |    3.684014ms |      172.19.0.1 | GET      "/"
job-board-app-1  | [GIN] 2022/09/27 - 14:10:10 | 200 |    3.791154ms |      172.19.0.1 | GET      "/jobs/54"
job-board-app-1  | [GIN] 2022/09/27 - 14:10:28 | 200 |    3.905699ms |      172.19.0.1 | GET      "/jobs/54/edit?token=tvtxz2yUaSZsK4ewEuRR1wtOlGs%3D"
@sethetter sethetter added the help wanted Extra attention is needed label Oct 7, 2022
@vicheanath
Copy link

I thinks for post request it should be pull all data on payload instead of query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sethetter @kevinfalting @vicheanath