Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onFocus and onBlur functionalities #17

Closed
KowsalyaPK opened this issue Mar 7, 2019 · 6 comments · May be fixed by #436
Closed

onFocus and onBlur functionalities #17

KowsalyaPK opened this issue Mar 7, 2019 · 6 comments · May be fixed by #436
Labels
enhancement New feature or request hacktoberfest Hacktoberfest 2020!

Comments

@KowsalyaPK
Copy link

  • Describe the Feature Request
    onFocus, onBlur, onInput are all default functionalities of any input, why not provide them here
@ajayns
Copy link
Contributor

ajayns commented Apr 13, 2019

Multiple inputs are used for this particular component, so how exactly do you propose these event handlers work? We'll need to consider all cases from empty, to partially filled to fully filled inputs

@nestoralonso
Copy link
Contributor

nestoralonso commented Oct 12, 2019

I may have a proposal for this on #75

In words it is like this:

  • If the previous focused element was another child input don't call onFocus
  • If the previous blurred element was another child input don't call onBlur

@apollonian apollonian added the enhancement New feature or request label Jul 6, 2020
@akashnimare akashnimare added the hacktoberfest Hacktoberfest 2020! label Sep 30, 2020
@Samibanley
Copy link

Can I give this one a try?

@codedoc7
Copy link

codedoc7 commented Oct 2, 2020

  • Describe the Feature Request
    onFocus, onBlur, onInput are all default functionalities of any input, why not provide them here

It is called because you run the function in the render method, you should pass function, not what they return.
Change -->
onFocus={this._onFocus()}
onBlur={this._onBlur()}
to this-->
onFocus={this._onFocus}
onBlur={this._onBlur}

@deepanshu2506
Copy link

working on it

@demarchenac
Copy link

Hi @prateek3255 ! I'll fix the suggestions for the closed PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Hacktoberfest 2020!
Projects
None yet
10 participants