fix: fixing failed build (#4)

* fix: fixing failed build

* docs: update doc deprecated minifier attribute

* docs: update docs Todo list

Author: prakasa1904

.gitignore

@@ -1 +1,2 @@
-caddy
+caddy
+.DS_Store

Makefile

@@ -1,17 +1,14 @@
 check-module:
 	@xcaddy list-modules
 
-run-module:
-	xcaddy run -c example/caddy.json
-
-run-module-caddy:
-	xcaddy run -c example/Caddyfile
-
 build-module:
-	xcaddy build v2.7.6 --with github.com/devetek/caddyserver-minifier@main=./
+	xcaddy build v2.10.0 --with github.com/devetek/caddyserver-minifier@main=./
+
+run-jsonfile:
+	./caddy run --config example/caddy.json
 
-run-build-module:
-	./caddy run -c example/caddy.json
+run-caddyfile:
+	./caddy run --config example/Caddyfile
 
 run-test:
 	@go test -v -cover ./...

README.md

@@ -39,7 +39,6 @@ http://localhost:9200 {
 	route {
 		minifier {
 			html {
-				KeepConditionalComments true
 				KeepSpecialComments true
 				KeepComments true
 				KeepWhitespace true
@@ -56,6 +55,7 @@ http://localhost:9200 {
 
 ## Todo
 
+- [ ] add Github Action CI to main code quality
 - [ ] Support for another `Content-Type` (css, js, etc):
 
 ```sh

caddyfile.go

@@ -104,12 +104,6 @@ func (m *Middleware) UnmarshalCaddyfile(d *caddyfile.Dispenser) error {
 						m.Html.KeepQuotes = converterStrToBoolean(d.Val())
 					}
 
-					if d.Val() == "KeepConditionalComments" {
-						// get value from config
-						d.NextArg()
-						m.Html.KeepConditionalComments = converterStrToBoolean(d.Val())
-					}
-
 					if d.Val() == "KeepSpecialComments" {
 						// get value from config
 						d.NextArg()

example/Caddyfile

@@ -3,7 +3,6 @@ http://localhost:9200 {
 		encode zstd gzip
 		minifier {
 			html {
-				KeepConditionalComments	true
 				KeepSpecialComments		true
 				KeepComments			true
 				KeepWhitespace			true
@@ -13,6 +12,6 @@ http://localhost:9200 {
 				KeepQuotes				true
 			}
 		}
-		reverse_proxy localhost:8097
+		reverse_proxy localhost:3000
 	}
 }

example/caddy-2.json

@@ -2,28 +2,84 @@
   "apps": {
     "http": {
       "servers": {
-        "example": {
-          "listen": [":9200"],
+        "srv0": {
+          "listen": [
+            ":9200"
+          ],
           "routes": [
             {
-              "match": [{ "host": ["localhost"] }],
-              "handle": [
+              "match": [
                 {
-                  "handler": "minifier"
-                },
+                  "host": [
+                    "localhost"
+                  ]
+                }
+              ],
+              "handle": [
                 {
-                  "handler": "reverse_proxy",
-                  "upstreams": [
+                  "handler": "subroute",
+                  "routes": [
                     {
-                      "dial": "localhost:8097"
+                      "handle": [
+                        {
+                          "handler": "subroute",
+                          "routes": [
+                            {
+                              "handle": [
+                                {
+                                  "encodings": {
+                                    "gzip": {},
+                                    "zstd": {}
+                                  },
+                                  "handler": "encode",
+                                  "prefer": [
+                                    "zstd",
+                                    "gzip"
+                                  ]
+                                },
+                                {
+                                  "Html": {
+                                    "KeepComments": true,
+                                    "KeepDefaultAttrVals": true,
+                                    "KeepDocumentTags": true,
+                                    "KeepEndTags": true,
+                                    "KeepQuotes": true,
+                                    "KeepSpecialComments": true,
+                                    "KeepWhitespace": true,
+                                    "TemplateDelims": [
+                                      "",
+                                      ""
+                                    ]
+                                  },
+                                  "handler": "minifier"
+                                },
+                                {
+                                  "handler": "reverse_proxy",
+                                  "upstreams": [
+                                    {
+                                      "dial": "localhost:3000"
+                                    }
+                                  ]
+                                }
+                              ]
+                            }
+                          ]
+                        }
+                      ]
                     }
                   ]
                 }
-              ]
+              ],
+              "terminal": true
             }
-          ]
+          ],
+          "automatic_https": {
+            "skip": [
+              "localhost"
+            ]
+          }
         }
       }
     }
   }
-}
+}