Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate type definitions for Client Libraries #27

Merged
merged 20 commits into from
Jun 11, 2024
Merged

Generate type definitions for Client Libraries #27

merged 20 commits into from
Jun 11, 2024

Conversation

Iamdavidonuh
Copy link
Collaborator

@Iamdavidonuh Iamdavidonuh commented Jun 8, 2024 •
edited
Loading

This PR Addresses some points in #17

@Iamdavidonuh Iamdavidonuh requested a review from deven96 June 8, 2024 09:10
@Iamdavidonuh Iamdavidonuh mentioned this pull request Jun 8, 2024
Open
deven96
deven96 reviewed Jun 8, 2024
View reviewed changes
ahnlich/types/src/query.rs Outdated Show resolved Hide resolved
deven96
deven96 reviewed Jun 8, 2024
View reviewed changes
ahnlich/types/src/query.rs Outdated Show resolved Hide resolved
deven96
deven96 reviewed Jun 8, 2024
View reviewed changes
ahnlich/types/src/query.rs Outdated Show resolved Hide resolved
deven96
deven96 reviewed Jun 9, 2024
View reviewed changes
ahnlich/typegen/src/main.rs Outdated Show resolved Hide resolved
@Iamdavidonuh Iamdavidonuh marked this pull request as ready for review June 10, 2024 14:52
@Iamdavidonuh Iamdavidonuh requested a review from deven96 June 10, 2024 14:54
deven96
deven96 requested changes Jun 10, 2024
View reviewed changes
ahnlich/typegen/src/main.rs Outdated Show resolved Hide resolved
ahnlich/typegen/src/main.rs Outdated Show resolved Hide resolved
ahnlich/typegen/src/main.rs Outdated Show resolved Hide resolved
ahnlich/typegen/src/main.rs Outdated Show resolved Hide resolved
ahnlich/typegen/src/tracers/mod.rs Outdated Show resolved Hide resolved
@Iamdavidonuh
Copy link
Collaborator Author

Iamdavidonuh commented Jun 11, 2024 •
edited
Loading

@deven96 This change will break the typesgen test since a change was made in the types crate.

@Iamdavidonuh Iamdavidonuh requested a review from deven96 June 11, 2024 13:39
@deven96 deven96 merged commit 530699f into main Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deven96 deven96 deven96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Iamdavidonuh @deven96