Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Moving vectors to fallible vectors #103

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

deven96
Copy link
Owner

@deven96 deven96 commented Sep 11, 2024

No description provided.

Copy link

github-actions bot commented Sep 11, 2024

Test Results

108 tests   108 ✅  1m 21s ⏱️
  7 suites    0 💤
  2 files      0 ❌

Results for commit 1ed9df6.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 11, 2024

Benchmark Results

group                                                        main                                   pr
-----                                                        ----                                   --
store_batch_insertion_without_predicates/size_100            1.05  1662.7±32.18µs        ? ?/sec    1.00  1584.6±38.19µs        ? ?/sec
store_batch_insertion_without_predicates/size_1000           1.05     17.3±0.29ms        ? ?/sec    1.00     16.5±0.39ms        ? ?/sec
store_batch_insertion_without_predicates/size_10000          1.03    174.1±3.82ms        ? ?/sec    1.00    168.4±2.46ms        ? ?/sec
store_batch_insertion_without_predicates/size_100000         1.02  1739.5±25.86ms        ? ?/sec    1.00  1703.2±27.15ms        ? ?/sec
store_retrieval_no_condition/size_100                        1.04      2.6±0.03ms        ? ?/sec    1.00      2.6±0.03ms        ? ?/sec
store_retrieval_no_condition/size_1000                       1.02     19.1±0.26ms        ? ?/sec    1.00     18.6±0.23ms        ? ?/sec
store_retrieval_no_condition/size_10000                      1.02    187.8±2.10ms        ? ?/sec    1.00    184.5±3.43ms        ? ?/sec
store_retrieval_no_condition/size_100000                     1.01  1905.0±27.92ms        ? ?/sec    1.00  1893.0±22.79ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100                   1.04      2.8±0.03ms        ? ?/sec    1.00      2.7±0.04ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_1000                  1.00     20.6±0.30ms        ? ?/sec    1.00     20.7±0.28ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_10000                 1.01    203.1±1.39ms        ? ?/sec    1.00    200.2±2.12ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100000                1.01       2.1±0.03s        ? ?/sec    1.00       2.1±0.03s        ? ?/sec
store_sequential_insertion_without_predicates/size_100       1.03  1657.0±29.01µs        ? ?/sec    1.00  1608.9±47.03µs        ? ?/sec
store_sequential_insertion_without_predicates/size_1000      1.05     17.3±0.46ms        ? ?/sec    1.00     16.4±0.30ms        ? ?/sec
store_sequential_insertion_without_predicates/size_10000     1.08    173.3±2.50ms        ? ?/sec    1.00    161.0±4.38ms        ? ?/sec
store_sequential_insertion_without_predicates/size_100000    1.00  1651.1±37.51ms        ? ?/sec    1.02  1677.4±20.40ms        ? ?/sec

@deven96 deven96 force-pushed the diretnan/fallible-collections branch from 2495974 to 1ed9df6 Compare September 11, 2024 03:18
@Iamdavidonuh Iamdavidonuh self-requested a review September 11, 2024 10:58
@Iamdavidonuh Iamdavidonuh marked this pull request as ready for review September 11, 2024 10:58
@Iamdavidonuh Iamdavidonuh merged commit 75593cd into main Sep 11, 2024
5 checks passed
@deven96
Copy link
Owner Author

deven96 commented Sep 11, 2024

Does a bit of #100

What's left is swapping out the places where we did .collect(), and then doing the process for HashMap as well. Doesn't seem like HashSet has any entry in fallible collections

@deven96 deven96 deleted the diretnan/fallible-collections branch November 27, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants