Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Layer Attribution Option #545

Open
wildintellect opened this issue Jun 13, 2024 · 1 comment
Open

[BUG] Layer Attribution Option #545

wildintellect opened this issue Jun 13, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@wildintellect
Copy link

wildintellect commented Jun 13, 2024

Context

What results were you expecting?

Some external layers require attribution as part of their licensing and terms of use. Many mapping libraries implement this as an attribution key on a layer definition that becomes a rendered over the map static text (sometimes HTML is supported).

BaseMap Layers might already have this specified in their style json, but will likely come up with many layer types particularly BitMapTileLayer where an external XYZ tile service is used.
https://maplibre.org/maplibre-style-spec/sources/#attribution
https://maplibre.org/maplibre-gl-js/docs/API/classes/AttributionControl/

This may not be a critical feature for users viewing their own notebooks, but will be an issue as they shared rendered notebooks or export images.

@wildintellect wildintellect added bug Something isn't working enhancement New feature or request labels Jun 13, 2024
@kylebarron
Copy link
Member

This is somewhat related to ideas I've had about letting users add to the underlying Maplibre map, e.g. through custom basemap styles #494. But there's also a question of how tied Lonboard should be to Maplibre. It makes some things like this simpler but also makes other things harder, because tying us to maplibre ties us to Web Mercator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants