Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpolated zero values are taken as false (zeros are not diplayed) #40

Open
aral opened this issue Mar 25, 2023 · 1 comment · Fixed by dodoas/stringjsx#3
Open

Interpolated zero values are taken as false (zeros are not diplayed) #40

aral opened this issue Mar 25, 2023 · 1 comment · Fixed by dodoas/stringjsx#3

Comments

@aral
Copy link

aral commented Mar 25, 2023

PR incoming.
@aral aral mentioned this issue Mar 27, 2023
Open
@vdsabev
Copy link

vdsabev commented Sep 11, 2023

Just bumped into this issue. My expectation that all numbers would render was so high that I thought it was a problem with my database.

odinhb added a commit to dodoas/stringjsx that referenced this issue Mar 8, 2024
@odinhb
Render literals like vanilla js template strings
79e1be4 
fixes developit#40
and developit#37

inspired by developit#41

The only place we don't have parity right now is arrays (because that's
how children are passed) and bigint (because I'm not gonna do dependency
wrangling rn)
@odinhb odinhb mentioned this issue Mar 8, 2024
Merged
odinhb added a commit to dodoas/stringjsx that referenced this issue Mar 8, 2024
@odinhb
Render literals like vanilla js template strings
8a669e1 
fixes developit#40
and developit#37

inspired by developit#41

The only place we don't have parity right now is arrays (because that's
how children are passed) and bigint (because I'm not gonna do dependency
wrangling rn)
@jcubic jcubic mentioned this issue Mar 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Render interpolated values correctly dodoas/stringjsx
2 participants
@aral @vdsabev