Added building inside one docker command and fixed sometimes db not

ready.

Author: developersCradle

Dockerfile

@@ -1,4 +1,19 @@
-FROM openjdk:17
-add target/*.jar rest-demo.jar
-ENTRYPOINT ["java", "-jar", "rest-demo.jar"]
+# Has Maven.
+FROM maven:3.8.8-eclipse-temurin-17 AS build
 
+WORKDIR /app
+
+COPY pom.xml .
+COPY src ./src
+
+# Run maven.
+RUN mvn clean package -DskipTests
+
+# Next, run the application.
+FROM openjdk:17-jdk-slim
+
+WORKDIR /app
+
+COPY --from=build /app/target/*.jar rest-demo.jar
+
+ENTRYPOINT ["java", "-jar", "rest-demo.jar"]

README.md

@@ -3,7 +3,7 @@
     <img id="codemen" src="codemen.png">
 </p>
 
-## Backend task Eng
+## Backend task Eng.
 
 Back End should include API's compliant with REST. It should include following actions:
 Adding user,
@@ -19,7 +19,7 @@ Description of data from API:
 
 https://jsonplaceholder.typicode.com/users
 
-## Backend task Fin
+## Backend task Fin.
 
 Back Endissä tulisi olla REST rajapinnat käyttäjien lisäämiseen, poistamiseen ja muokkaamiseen, kaikkien käyttäjien hakemiseen siivutettuna sekä vielä käyttäjien hakemiseen nimen perusteella.
 
@@ -30,73 +30,72 @@ Rajapinnan datasta:
 
 https://jsonplaceholder.typicode.com/users
 
-### Checklist
+### Checklist.
 
 - ~~Spring API documentation.~~ ✔️
-[Open-API](https://springdoc.org/#getting-started) was used, because Swagger current version didn't support the newest Spring Boot. To look documentation, navigate to `http://localhost:8080/swagger-ui/index.html`
-    - ~~Look for example [Swagger](https://www.baeldung.com/swagger-2-documentation-for-spring-rest-api)~~
-- ~~Some database~~ ✔️
-MySQL
+[Open-API](https://springdoc.org/#getting-started) was used, because Swagger current version didn't support the newest Spring Boot. To look documentation, navigate to `http://localhost:8080/swagger-ui/index.html`.
+    - ~~Look for example [Swagger](https://www.baeldung.com/swagger-2-documentation-for-spring-rest-api)~~.
+- ~~Some database~~. ✔️
+MySQL.
     - ~~Some way to initialize random users.~~ ✔️
-    `@PostConstruct`
-        - ~~For example MySQL or Spring Boot initializing way~~
-            - ~~Creating database startup mechanism~~ ✔️
-            Hibernate takes care of creating database and table 
-- ~~Make instructions `.md`~~ ✔️
-- ~~CRUD operations~~ ✔️
-    - ~~Add~~ ✔️ 
+    `@PostConstruct`.
+        - ~~For example MySQL or Spring Boot initializing way~~.
+            - ~~Creating database startup mechanism~~. ✔️
+            Hibernate takes care of creating database and table. 
+- ~~Make instructions `.md`~~. ✔️
+- ~~CRUD operations~~. ✔️
+    - ~~Add~~. ✔️ 
     Adding user is done making **POST** message to `/api/v1/users`.
-    - ~~Remove~~ ✔️ 
-    Removing user is done making **DELETE** message to `/api/v1/users/{userId}`
-    - ~~Modify **PUT**(PUT/POST/PATCH)~~ ✔️ 
-    Modifying user is done making **PUT** message to `/api/v1/users`
-    - ~~Read~~ ✔️ 
-    Return all users when making **GET** request to `/api/v1/users`
-        - ~~Return all as paged~~ ✔️
+    - ~~Remove~~. ✔️ 
+    Removing user is done making **DELETE** message to `/api/v1/users/{userId}`.
+    - ~~Modify **PUT**(PUT/POST/PATCH)~~. ✔️ 
+    Modifying user is done making **PUT** message to `/api/v1/users`.
+    - ~~Read~~. ✔️ 
+    Return all users when making **GET** request to `/api/v1/users`.
+        - ~~Return all as paged~~. ✔️
         Returns wanted amount of users, when perform **GET** message `/api/v1/users?pageSize=10` where `pageSize` URL parameter is present.
-            - ~~Simple paging~~
-                - ~~[Possible paging](https://docs.spring.io/spring-data/rest/docs/2.0.0.M1/reference/html/paging-chapter.html)~~
-        - ~~Return users based on name~~ ✔️
+            - ~~Simple paging~~.
+                - ~~[Possible paging](https://docs.spring.io/spring-data/rest/docs/2.0.0.M1/reference/html/paging-chapter.html)~~.
+        - ~~Return users based on name~~. ✔️
         Returns all users based on name, when perform **GET** message to`/api/v1/users?name=pekka` here `name` URL parameter is present.
-- ~~Tests~~ ✔️ 
+- ~~Tests~~. ✔️ 
 Service level tests. 
     - ~~Following error were introduced when using plain old Eclipse `error java.lang.NoSuchMethodError: 'java.util.Set`.~~ ✔️
-    This was fixed using `Spring Tools 4 for Eclipse`
+    This was fixed using `Spring Tools 4 for Eclipse`.
     - Unit tests were not introduced since business logic was fairly simple.
     - ~~Option to add docker to tests, so test db and production db data won't get mixed up.~~ ✔️
-- Other bonuses would be to implement sort, offset and indexes into query logic. (BONUS)
+- Other bonuses would be to implement sort, offset and indexes into query logic. (BONUS).
 - For the sake of time authentication was not introduced. If there would be such a time, usage of `JWT Bearer Token to Swagger` would be an option to go.
-- ~~Get user with specified userId with GET message. (BONUS)~~ ✔️
-Do **GET** request for following address `/api/v1/users/{userId}`
-- ~~Add support for saving multiple users at same time. This is for `saveAll()`. [BatchInserts](https://www.baeldung.com/spring-data-jpa-batch-inserts) (BONUS)~~ ✔️ 
+- ~~Get user with specified userId with GET message. (BONUS)~~. ✔️
+Do **GET** request for following address `/api/v1/users/{userId}`.
+- ~~Add support for saving multiple users at same time. This is for `saveAll()` [BatchInserts](https://www.baeldung.com/spring-data-jpa-batch-inserts) (BONUS)~~. ✔️ 
 
-# How to run (Recommended)
+# How to run (Recommended).
 
-> Requirements for running locally
-> 1. Have Docker. Tested with [Docker Desktop 4.25.2](https://www.docker.com/)
+> Requirements for running locally:
+> 1. Have Docker. Tested with [Docker Desktop 4.25.2](https://www.docker.com/).
 
-1. Pull repository
-2. Go to the project folder
-3. Execute `./mvnw package` to build `.jar` file
-4. Execute with Docker `docker-compose up --build`
-5. Go to documentation and start using `http://localhost:8080/swagger-ui/index.html`
+1. Pull repository.
+2. Go to the project folder.
+3. Execute with Docker `docker-compose up --build`.
+4. Go to documentation and start using `http://localhost:8080/swagger-ui/index.html`.
 
-- **Only starting inside IDE**. Starting in Eclipse IDE for debugging purposes. We can start db separately and then start debug version from Eclipse IDE. Starting db from docker independently `docker run -d -p 3307:3306 --name mysqldb -e MYSQL_ROOT_PASSWORD=root -e MYSQL_DATABASE=user_rest_demo mysql`
+- **Only starting inside IDE**. Starting in Eclipse IDE for debugging purposes. We can start db separately and then start debug version from Eclipse IDE. Starting db from docker independently `docker run -d -p 3307:3306 --name mysqldb -e MYSQL_ROOT_PASSWORD=root -e MYSQL_DATABASE=user_rest_demo mysql`.
 
-- For the future, if there is time, there should be a way to build all in one command and set this process up. 
+- ~~For the future, if there is time, there should be a way to build all in one command and set this process up.~~ 
 
-# How to run (Optional, old way)
+# How to run (Optional, old way).
 
-> Requirements for running locally
-> 1. Java JDK 17 minimum. Tested with [OpenJDK21](https://jdk.java.net/21/)
-> 2. MySQL server running. Tested with [MySQL 8.x.xx](https://dev.mysql.com/downloads/installer/). Server should be running in port `3306` and root password **root** and root user **root**
+> Requirements for running locally.
+> 1. Java JDK 17 minimum. Tested with [OpenJDK21](https://jdk.java.net/21/).
+> 2. MySQL server running. Tested with [MySQL 8.x.xx](https://dev.mysql.com/downloads/installer/). Server should be running in port `3306` and root password **root** and root user **root**.
 
-> Maven should not be needed since using Maven wrapper `mvnw` 
-> Docker is needed to run tests
+> Maven should not be needed since using Maven wrapper `mvnw`. 
+> Docker is needed to run tests.
 
-1. Pull repository
-2. Go to the project folder and build the `.jar` file and execute. `./mvnw spring-boot:run`
-3. Go to documentation and start using `http://localhost:8080/swagger-ui/index.html`
+1. Pull repository.
+2. Go to the project folder and build the `.jar` file and execute. `./mvnw spring-boot:run`.
+3. Go to documentation and start using `http://localhost:8080/swagger-ui/index.html`.
 
 - This has been tested. ✔️
 ~~For the future, if there is time, there should be a docker image for setting this process up.~~ 

docker-compose.yml

@@ -12,6 +12,9 @@ services:
       MYSQL_USER: root
       MYSQL_PASSWORD: root
       MYSQL_PORT: 3306
+    depends_on: # Ensure db running first before springboot app
+      - mysqldb
+
   mysqldb: # When same name, docker will create under same network
     container_name: mysqldb # When same name, docker will create under same network
     image: mysql

src/main/resources/application.properties

@@ -1,9 +1,12 @@
-#spring.jpa.hibernate.ddl-auto=update
 #spring.datasource.url=jdbc:mysql://${MYSQL_HOST:localhost}:${MYSQL_PORT:3306}/user_rest_demo?createDatabaseIfNotExist=true
 #spring.datasource.username=${MYSQL_USER:root}
 #spring.datasource.password=${MYSQL_PASSWORD:root}
 
-spring.datasource.url=jdbc:mysql://localhost:3306/user_rest_demo?createDatabaseIfNotExist=true
+# Below should be used if db start from  Docker container!
+spring.datasource.url=jdbc:mysql://mysqldb:3306/user_rest_demo?createDatabaseIfNotExist=true&allowPublicKeyRetrieval=true
+# Below should be used if db start locally!
+# spring.datasource.url=jdbc:mysql://localhost:3306/user_rest_demo?createDatabaseIfNotExist=true
+
 spring.datasource.username=root
 spring.datasource.password=root