Patch modules loaded via relative paths

[guiprav]

Hi, Russ.

Is it not possible to patch modules loaded from a relative path (e.g. require('./foo') or require('../src/bar'))? If not, is there a reason for it?

Thanks.

P.S.: I tried adding a 'question' tag to this issue, but I couldn't find it. Not sure if GitHub is buggy today or if you disabled it ^_^

[devdazed]

It should be patching this, I am labeling this as a bug. I think it has to do with the way the patch module resolves.

[guiprav]

Yeah, I it's probably because require.resolve will resolve relative to the calling file, which is patch.js, not the file where patch() was called from. The fix is probably as simple as detecting a relative path and prepending '../../' to it or something. If I get to fix it this weekend, I'll send you a pull request.

Thank you.

On Fri, Jul 5, 2013 at 5:45 PM, Russ Bradberry [email protected]:

It should be patching this, I am labeling this as a bug. I think it has to
do with the way the patch module resolves.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-20538196
.

[guiprav]

Looks like fixing that would break the API as well, haha. I just found Sinon, too. It looks awesome. Looks like it's got all the features I imagined for SuperMock plus a lot more. I'll be using it for my projects from now on. Good luck with SuperMock.