Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Send logs to seperate channel #11

Open
Merith-TK opened this issue May 22, 2023 · 2 comments
Open

[feature] Send logs to seperate channel #11

Merith-TK opened this issue May 22, 2023 · 2 comments
Labels
enhancement New feature or request Minecraft to Discord A feature going Minecraft chat to Discord chat stashed Currently stashed away, but will be looked at in the future

Comments

@Merith-TK
Copy link

Merith-TK commented May 22, 2023

I was hoping it would be possible to (on server shutdown or crash) upload latest.log rather than latest crash log? sometimes crashlogs are useless on fabric/quilt when the error is actually only in the latest.log file

And the option to have the bot send the log link to an seperate channel rather than the same chat link channel

@asoji
Copy link
Member

asoji commented Aug 10, 2023

It's a good idea, but from what I'm hearing from @maximumpower55, this would require a significant rewrite, since the mod is built upon just one webhook right now.

@asoji asoji added enhancement New feature or request Minecraft to Discord A feature going Minecraft chat to Discord chat stashed Currently stashed away, but will be looked at in the future labels Aug 10, 2023
@Merith-TK
Copy link
Author

I don't think it would require one? Just an

If config.LogWebhook != "" Then
  Send log to config.LogWebhook
Else
  Carry on

And the webhook send function could be altered to accept an argument internally for an specified webhook, and then just call the config variable for the argument like

send(conf.Webhook, [the other data needed ...])?

I haven't looked at the mod code but this is how I would do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Minecraft to Discord A feature going Minecraft chat to Discord chat stashed Currently stashed away, but will be looked at in the future
Projects
None yet
Development

No branches or pull requests

2 participants