Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--fromfile broken? #11

Open
spilinek opened this issue Jan 13, 2023 · 0 comments
Open

--fromfile broken? #11

spilinek opened this issue Jan 13, 2023 · 0 comments

Comments

@spilinek
Copy link

This isn't working with --fromfile:
Skyscraper -p ps2 -s screenscraper --fromfile /home/user/.skyscraper/reports/reports-ps2-missing_ages-20230112.txt

This works with --includefrom:
Skyscraper -p ps2 -s screenscraper --includefrom /home/user/.skyscraper/reports/reports-ps2-missing_ages-20230112.txt

I noticed in README.md the comment:
Version 3.7.0 (17th January 2022)
Moved '--fromfile' option to '--includefrom'. '--fromfile' still works, but is considered deprecated

Since --fromfile is considered deprecated we should update the docs to suggest using --includefrom instead of --fromfile. The README.md and CLIHELP.md both would need updates. This would help avoid a lot of frustration when --fromfile doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant