-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve description of optical distortion #22
Comments
@sbailey Are the data files in this package under change control? What are the logistics of adding a new file? |
We do not have a formal change control procedure for updating desimodel. The guidelines are:
i.e. in this particular case, let's have Pat/Bobby/Tim add the data file to a DocDB entry, also put it under desimodel data/inputs/ (perhaps in a new |
Just waiting for Pat/Bobby/Tim to add the data file to DESI-347 in DocDB before closing this issue... |
Did this ever get resolved? We need to know if there are changes to theses files coming that will in turn change the data model. |
I am reassigning to @sbailey since I have already provided the file so the next step is to knock on some doors. |
Adding label 'data model' note that fixing this issue will also involve changes to the data model. If that is not the case, please remove the label. |
The current fiberloss calculation in
bin/fiberloss.py
readsdata/inputs/throughput/DESI-0347-throughput.txt
from this package, and uses the blur values plotted below:This file also includes a column of lateral offset values (also in the plot), but the code uses a fixed value of 0.2" instead.
This issue is to provide a more detailed tabulation of the optical distortion that matches this graph based on ray tracing spots from the "geometric blur" tab of the excel spreadsheet in desi-doc-347-v10:
The main difference is that distortion is tabulated simultaneously in field angle and wavelength, and so captures significant correlations that are missing from the existing
platescale.txt
table.I also want to understand how the values in
DESI-0347-throughput.txt
were calculated from the ray tracing spots.The text was updated successfully, but these errors were encountered: