Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

positioner matched to multiple spots #20

Open
sbailey opened this issue Jan 8, 2020 · 2 comments
Open

positioner matched to multiple spots #20

sbailey opened this issue Jan 8, 2020 · 2 comments

Comments

@sbailey
Copy link
Collaborator

sbailey commented Jan 8, 2020

Using same example as #19:

basedir=/project/projectdirs/desi/spectro/data/20200107/00038674
desi_fvc_proc \
  --infile $basedir/fvc-00038674.fits.fz \
  --expected $basedir/coordinates-00038674.fits \
  --outfile spots-00038674.csv

there are several positioners that are matched to more than one spot, sometimes very far away, e.g.:

from astropy.table import Table
from collections import Counter
x = Table.read('spots-00038674.csv')
for (petal, loc, pinhole), n in Counter(zip(x['PETAL_LOC'], x['DEVICE_LOC'], x['PINHOLE_ID'])).items(): 
    if n>1: 
        print(petal, loc, pinhole, n) 

0 533 0 4
0 509 0 2
0 409 0 2
0 224 0 2
0 205 0 2
0 157 0 2
8 350 0 2
8 248 0 2
7 24 0 2
6 159 0 2
3 494 0 2
7 377 0 2
4 134 0 2
7 443 0 2
7 397 0 2
6 437 0 2

The first case (PETAL_LOC=0 DEVICE_LOC=533) is the fiducial reported in #19, but the others are positioners, e.g.

x['XPIX', 'YPIX', 'DEVICE_LOC', 'PINHOLE_ID'][x['LOCATION'] == 509] 

<Table length=2>
       XPIX               YPIX       DEVICE_LOC PINHOLE_ID
     float64            float64        int64      int64   
------------------ ----------------- ---------- ----------
2667.6594170561475 540.0779076216791        509          0
 2695.654126737584 565.4560307807191        509          0

image

@julienguy
Copy link
Collaborator

is it still not working?

@julienguy
Copy link
Collaborator

Fixed in PR #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants