Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get airspeed velocity benchmarks working again (PyInf#12733) #343

Open
ArvidJB opened this issue Jun 18, 2024 · 3 comments · May be fixed by #377
Open

Get airspeed velocity benchmarks working again (PyInf#12733) #343

ArvidJB opened this issue Jun 18, 2024 · 3 comments · May be fixed by #377
Assignees

Comments

@ArvidJB
Copy link
Collaborator

ArvidJB commented Jun 18, 2024

Not sure when the benchmarks stopped working...
We used to automatically populate https://deshaw.github.io/versioned-hdf5/benchmarks on every commit by running airspeed velocity.

Let's get this working again!

Also, we may want to update the benchmarks
https://deshaw.github.io/versioned-hdf5/master/performance.html
All of this is probably much faster now?

@peytondmurray peytondmurray self-assigned this Jun 18, 2024
@asmeurer
Copy link
Collaborator

asmeurer commented Jul 3, 2024

The benchmarks were never run automatically. I just ran them on my computer every once in a while. asv automatically includes all commits when you run it. It's hard to run long term benchmarks on CI because you can't really be sure you have a consistent runtime across runs.

@asmeurer
Copy link
Collaborator

asmeurer commented Jul 3, 2024

You can use CI to run a comparison benchmark between the PR and master, because the runs will be consistent for the same runner. We do this in SymPy https://github.com/sympy/sympy/blob/0710d784347042c54270fd562a47317607b9be30/.github/workflows/runtests.yml#L482 https://github.com/sympy/sympy/blob/master/.github/workflows/comment-on-pr.yml

@peytondmurray
Copy link
Collaborator

@ArvidJB I just filed a request to allow cirun.io permissions for this repo so that we can run benchmarks on AWS. Once we have that enabled, we should be able to do run this quickly.

@peytondmurray peytondmurray linked a pull request Oct 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants