Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace utils's cached_attribute by functools' cached_property #298

Open
Carreau opened this issue Feb 7, 2024 · 1 comment
Open

Replace utils's cached_attribute by functools' cached_property #298

Carreau opened this issue Feb 7, 2024 · 1 comment

Comments

@Carreau
Copy link
Collaborator

Carreau commented Feb 7, 2024

They are AFAICT the same execpt the functools one is more likely to work with type inference.
@Carreau Carreau changed the title Repalce utils's cache_attribute by functools cached_property Replace utils's cache_attribute by functools cached_property Mar 1, 2024
@Carreau Carreau changed the title Replace utils's cache_attribute by functools cached_property Replace utils's cached_attribute by functools cached_property Mar 4, 2024
@Carreau Carreau changed the title Replace utils's cached_attribute by functools cached_property Replace utils's cached_attribute by functools' cached_property Mar 4, 2024
@Carreau
Copy link
Collaborator Author

Carreau commented Mar 12, 2024

Partially done as part of #315, but by doing a indirect import. It would be good to do mass rename/import for readability/consistency but I'm trying to avoid mass modifications.

Carreau added a commit to Carreau/pyflyby that referenced this issue Sep 20, 2024
@Carreau
Used cached_properly instead of cached_attribute
8a8ee1f 
See deshaw#298
@Carreau Carreau mentioned this issue Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Carreau