Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add heaviside to the NumPy import database #228

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Add heaviside to the NumPy import database #228

merged 1 commit into from
Apr 5, 2023

Conversation

asmeurer
Copy link
Collaborator

@asmeurer asmeurer commented Jan 5, 2023

Fixes #220.

@asmeurer asmeurer mentioned this pull request Jan 5, 2023
Open
@dshivashankar1994
Copy link
Collaborator

FTR, #220 is not just about adding NumPy import to the DB. Details at #220 (comment)

dshivashankar1994
dshivashankar1994 approved these changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@dshivashankar1994 dshivashankar1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge though

@peytondmurray
Copy link
Collaborator

@dshivashankar1994 Is there anything more that needs to be done here, or are you willing to merge this as-is?

@dshivashankar1994
Copy link
Collaborator

This PR is good to merge. #220 's underlying problem still exists though.

@swapojha swapojha merged commit 7c4a0d4 into deshaw:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshivashankar1994 dshivashankar1994 dshivashankar1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidy-imports doesn't include ufuncs when ran with "--replace-star-imports" (PyInf#8958)
4 participants
@asmeurer @dshivashankar1994 @peytondmurray @swapojha