Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-default execution_count #18

Open
FredrikBakken opened this issue Aug 23, 2024 · 0 comments
Open

Add support for non-default execution_count #18

FredrikBakken opened this issue Aug 23, 2024 · 0 comments

Comments

@FredrikBakken
Copy link

Hi there 👋

First of all - we're using the nbstripout-fast as an alternative to nbstripout and absolutely love the performance increase in our pre-commit 🚀 However, we do have a suggestion for a supported feature.

Context

To give a bit of context, we have a team of Data Engineers where Databricks is our main compute engine for processing our notebooks. Some of the developers prefer to work locally with DatabricksConnect, while others prefer to use the Databricks UI. We're working on supporting both alternatives so that our developers can be in the environment they feel most efficient. The developers that use DatabricksConnect are actively using pre-commit, while Databricks does not support pre-commit directly so their lint-step inside our pipelines fails every time - and often times with nbstripout-fast.

Summary

Databricks will automatically set the execution_count value to 0, while nbstripout-fast sets it to null.

Our request is therefore that a new flag is added to the nbstripout-fast so that we can set a non-default execution_count value to our pre-commit. Could e.g. be something like: --default-execution-count <VALUE>

@FredrikBakken FredrikBakken changed the title Add support for non-default value for execution_count Add support for non-default execution_count Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant