Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change implementation of OneDriveAPISession #40

Open
derrix060 opened this issue Dec 12, 2018 · 1 comment
Open

Change implementation of OneDriveAPISession #40

derrix060 opened this issue Dec 12, 2018 · 1 comment

Comments

@derrix060
Copy link
Owner

derrix060 commented Dec 12, 2018

OneDriveAPISession is using keyring at the moment and this requires some specifics from the environment that it is running on. Changing to a nice encryption method (like keyring).

one good start: https://cryptography.io/en/latest/fernet/#using-passwords-with-fernet.

The salt could be generated once and stored in the default config file, so it can be changed by the user if necessary.

The password could be some env variable, saved into a file or even as an argument. Remembering that this password/salt is specific per user.

@derrix060
Copy link
Owner Author

derrix060 commented Dec 12, 2018

I've tested encrypting and decrypting the same content that is saved into keyring at the moment generated by pickle (a byte-like representation of the session object) and works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant