-
Notifications
You must be signed in to change notification settings - Fork 10
Use Microsoft Graph API and get rid of not-supported onedrivesdk #26
Comments
Instead of re-write all the onedrive sdk and use it only on this project, I decided to fork the oficial sdk and make the changes there. Feel free to help me on this: https://github.com/OneDriveSDK/onedrive-sdk-python |
I'll help where I can, but I'm back to school next week so I won't do much. |
I was working on it yesterday, and almost all code changes are ready. I already get some information from Graph API in the code, I just need to make sure I can get everything. |
known issues:
|
Since Also I'm not sure if this is relevant, but should we maybe call |
Additionally, with the HTTPS connection we could: |
I've already created an issue to rename to
I liked the idea to move onedriveClient to the organization and I'm okay renaming it... Any suggestion for the "new" name?
This wouldn't change the problem because the problem is not to have the token, but is to receive the notification from the subscription. I've reopened the issue anyway.
That's the idea of NGROK. I got 404 when trying to access the link... |
Oh, okay. That seems strange. I might take a look sometime, if the changes ever get pushed to the repo (or a branch on it). |
I've pushed the changes here |
Working fine locally. I've also tested with docker and is okay. The key is to install the package using:
Please make sure to use a non-existent directory at this point, to avoid any conflict with the files. @modelmat can you double check to see if it's working, and if so, I'll submit a PR. |
Ok, on it. Does this have tests? |
Only the normal tests, the problem to test it, is I don't have a business account only for testing, and this won't be reliable at all. |
Okay, I was having issues with a keyerror, I believe it may be caused by a broken config - I'll try and delete it. I got slightly sidetracked, so I'm not able to go any further at the moment. Sorry :P |
finally got round to it, this error occurs. |
I just set this up after clearing all the config directories.
|
The above error is because was using a wrong backend. So is it working now? Can I merge this -break- change? |
The log above was an error? |
@modelmat correct, both are the same. I was referring to the longs that you put, more specifically to
|
So, is this not an issue? So it's still syncing from this? |
The current code is using a mix of old MS APIs.
This repo could authenticate using the new api, so it's something doable.
The text was updated successfully, but these errors were encountered: