optional rustls

[cataggar]

Would it be possible to make rustls an optional dependency? I'm not sure how to get around a couple of security warnings for ring briansmith/ring#1463, which is used by rustls.

It looks like the only direct dependency is in service_account.rs:

yup-oauth2/src/service_account.rs

Lines 20 to 25 in ac0e5f6

	use rustls::{
	self,
	internal::pemfile,
	sign::{self, SigningKey},
	PrivateKey,
	};

That was written long before pks8 library started. May be it can be used instead of rustls directly.
https://docs.rs/pkcs8/

Does that conceptually make sense?

[dermesser]

Sorry that I hadn't responded yet -- I have gated the service account code and rustls dependency (that, as you helpfully noticed, is only used by the former) behind the "service_account" feature. Would you please try if this helps your situation? If it does, I will publish this as a minor update (as the default behavior will not change).

[cataggar]

Thanks @dermesser. Unfortunately, it does not compile.

cargo check --no-default-features --features hyper-tls


error[E0412]: cannot find type `ServiceAccountFlowOpts` in this scope
   --> src\authenticator.rs:303:47
    |
301 | impl ApplicationDefaultCredentialsAuthenticator {
    |     - help: you might be missing a type parameter: `<ServiceAccountFlowOpts>`
302 |     /// Try to build ServiceAccountFlowOpts from the environment
303 |     pub async fn from_environment() -> Result<ServiceAccountFlowOpts, std::env::VarError> {
    |                                               ^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function `read_service_account_key` in the crate root
   --> src\authenticator.rs:305:20
    |
305 |             crate::read_service_account_key(std::env::var("GOOGLE_APPLICATION_CREDENTIALS")?)
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `parse_service_account_key`
    |
   ::: src\helper.rs:50:1
    |
50  | pub fn parse_service_account_key<S: AsRef<[u8]>>(key: S) -> io::Result<ServiceAccountKey> {
    | ----------------------------------------------------------------------------------------- similarly named function `parse_service_account_key` defined here

error[E0422]: cannot find struct, variant or union type `ServiceAccountFlowOpts` in this scope
   --> src\authenticator.rs:309:12
    |
309 |         Ok(ServiceAccountFlowOpts {
    |            ^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0412]: cannot find type `ServiceAccountFlowOpts` in this scope
   --> src\authenticator.rs:354:44
    |
349 | pub enum ApplicationDefaultCredentialsTypes<C>
    |                                              - help: you might be missing a type parameter: `, ServiceAccountFlowOpts`
...
354 |     ServiceAccount(AuthenticatorBuilder<C, ServiceAccountFlowOpts>),
    |                                            ^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0412]: cannot find type `ServiceAccountKey` in this scope
  --> src\helper.rs:50:72
   |
50 | pub fn parse_service_account_key<S: AsRef<[u8]>>(key: S) -> io::Result<ServiceAccountKey> {
   |                                                -                       ^^^^^^^^^^^^^^^^^ not found in this scope
   |                                                |
   |                                                help: you might be missing a type parameter: `, ServiceAccountKey`

error[E0282]: type annotations needed for `AuthenticatorBuilder<C, F>`
   --> src\authenticator.rs:337:16
    |
337 |             Ok(flow_opts) => {
    |                ^^^^^^^^^ cannot infer type
338 |                 let builder = AuthenticatorBuilder::new(flow_opts, client);
    |                     ------- consider giving `builder` the explicit type `AuthenticatorBuilder<C, F>`, with the type parameters specified

Some errors have detailed explanations: E0282, E0412, E0422, E0425.
For more information about an error, try `rustc --explain E0282`.
error: could not compile `yup-oauth2` due to 6 previous errors

[dermesser]

yes, I already merged your PR. I apparently didn't even correctly test it with the disabled service_account feature.