Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from dev #15

Merged
merged 10 commits into from
Feb 20, 2022
Merged

Merge changes from dev #15

merged 10 commits into from
Feb 20, 2022

Conversation

derickson2402
Copy link
Owner

This PR will add the following changes from dev, for release v0.5:

Dan Erickson added 5 commits February 6, 2022 03:47
Added the following to the wrapper script

- Automatically detect host OS
- Automatically detect if Docker is installed and running, provide instructions or turn it on if not
- Automatically detect an internet connection and pull the newest version of the container
- Use environment variables to change config
- Verify the user is fine with using Perf with SYS_ADMIN turned on

Also added command to the docs for automatically installing the script

See #8, #6
The arguments passed to Docker were not being expanded correctly. Fixed this by adding more variables dedicated to function parameters, and use ```eval``` to execute the command rather than running it directly.

This does bring up some security concerns since it would be non-trivial to execute arbitrary code using specially crafted arguments, but it is expected that people using the container are running code on their host machine anyways so this is a conversation for a different day.

See #8 (wrapper versatility)
Added support for input file redirection. This is not super well tested so there may be some issues, but it seems to be working well.

See #2 (Input redirection)
There was an extra ```shift``` in the wrapper script which was removed and accidentally re-added. This caused the script to ignore the first argument when running.
@derickson2402 derickson2402 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Feb 16, 2022
@derickson2402 derickson2402 self-assigned this Feb 16, 2022
Dan Erickson added 5 commits February 16, 2022 17:28
Cleaned up the organization of the Docker build layers. Now using seperate builder layers for cppcheck and golang, and dev container as the base for builders
The dnf mirrors that were fixed back in v0.4 apparently are known for poor uptime and performance, and seemed to be the cause of build failures. This was mostly happening in GitHub actions, but started happening locally too. Found a solution online which uses a different mirror.

Fixed the installation of cppcheck. It was not correctly linking to its configuration files, so added them.
@derickson2402 derickson2402 marked this pull request as ready for review February 20, 2022 03:50
@derickson2402 derickson2402 merged commit 0fb3670 into main Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
1 participant