-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge changes from dev #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the following to the wrapper script - Automatically detect host OS - Automatically detect if Docker is installed and running, provide instructions or turn it on if not - Automatically detect an internet connection and pull the newest version of the container - Use environment variables to change config - Verify the user is fine with using Perf with SYS_ADMIN turned on Also added command to the docs for automatically installing the script See #8, #6
The arguments passed to Docker were not being expanded correctly. Fixed this by adding more variables dedicated to function parameters, and use ```eval``` to execute the command rather than running it directly. This does bring up some security concerns since it would be non-trivial to execute arbitrary code using specially crafted arguments, but it is expected that people using the container are running code on their host machine anyways so this is a conversation for a different day. See #8 (wrapper versatility)
Added support for input file redirection. This is not super well tested so there may be some issues, but it seems to be working well. See #2 (Input redirection)
There was an extra ```shift``` in the wrapper script which was removed and accidentally re-added. This caused the script to ignore the first argument when running.
derickson2402
added
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Feb 16, 2022
Cleaned up the organization of the Docker build layers. Now using seperate builder layers for cppcheck and golang, and dev container as the base for builders
The dnf mirrors that were fixed back in v0.4 apparently are known for poor uptime and performance, and seemed to be the cause of build failures. This was mostly happening in GitHub actions, but started happening locally too. Found a solution online which uses a different mirror. Fixed the installation of cppcheck. It was not correctly linking to its configuration files, so added them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the following changes from dev, for release v0.5: