Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Automatically generate an ID, set a default repo, prefer systemd #77

Open
tibers opened this issue Nov 11, 2016 · 5 comments
Labels

Comments

@tibers
Copy link

tibers commented Nov 11, 2016

Hi Project!

I'd like to fathom the maintainer's opinions on a few things before writing code.

Repos: Right now for RPM based distros I've been using the cloudera repos for RPMs for installation. They give away their ZK rpm, so I'd like to propose work on params class to make that the default.

ID: Is there any aversion to assuming the hostname follows a standard naming pattern like myhost01, myhost02, myhost03? It should be pretty easy to grok the digits and make that the ID.

Systemd: If it's installed, why not prefer it?

@deric
Copy link
Owner

deric commented Nov 11, 2016

@tibers Any PRs are welcomed. Preferably in smaller chunks (each feature on PR).

  • RPMs: If the package is not provided by the distribution it should be ok. There seems to be a zookeeper package for Fedora (I'm not sure when it might land in RHEL or CentOS).
  • IDs: Sure, that's a good idea! I've experimented a bit with some kind of automatic ID discovery but in the end it wasn't reliable enough.
  • Systemd: yeah, we're trying something like that.

tibers pushed a commit to tibers/puppet-zookeeper that referenced this issue Nov 11, 2016
@tibers
Copy link
Author

tibers commented Nov 11, 2016

OK you've at least answered one of my questions - I'm using cloudera because they support CentOS 7.

@deric deric added the question label Nov 14, 2016
@deric
Copy link
Owner

deric commented Nov 14, 2016

Well the question is whether CentOS will include official ZooKeeper support or not. Cloudera is a 3rd party repository and not everyone must be fine with that. Currently we support also installation from source, so there are multiple options for each distribution.

@tibers
Copy link
Author

tibers commented Nov 17, 2016

I submitted a PR with the host to ID stuff done in regex but I'm getting completely hosed by the facts hash apparently not being populated from the docker containers travisCI creates. Any suggestions?

@deric
Copy link
Owner

deric commented Nov 21, 2016

Well basically this is the same problem as we're discussing in #18. I've written some sort of solution in 8f2477c but it didn't seem to be consistent enough (I can't recall what was the problem, maybe it's just missing tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants