Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aria-roles standards object contains many roles that are classified as widgets but are not #4371

Closed
straker opened this issue Mar 13, 2024 · 2 comments · Fixed by #4421
Closed

Aria-roles standards object contains many roles that are classified as widgets but are not #4371

straker opened this issue Mar 13, 2024 · 2 comments · Fixed by #4421
Assignees
@straker @gaiety-deque
Labels
fix Bug fixes rules Issue or false result from an axe-core rule standards Issues in the ARIA standards objects (lib/standards) support target-size
Milestone
Axe-core 4.9.1

Comments

@straker
Copy link
Contributor

straker commented Mar 13, 2024

Role such as tabpanel, timer, alert, etc. are marked as widgets but they shouldn't be. This problem is contributing to #4360 as each example uses a tabpanel with many overlapping child nodes.

We'll need to investigate the ramifications of changing these to their correct types before we make the change.
@straker straker added the standards Issues in the ARIA standards objects (lib/standards) label Mar 13, 2024
@straker straker added this to the Axe-core 4.9.0 milestone Mar 13, 2024
@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule support target-size labels Mar 27, 2024
@WilcoFiers
Copy link
Contributor

An example where this is creating a false positive is on https://www.hep.ca/horse-insurance/. The close button the cookie banner is 15x15. Axe is failing this for being too close to the to the cookie banner, which has tabindex=0 and role=alert.

@gaiety-deque
Copy link
Contributor

gaiety-deque commented Apr 22, 2024 •
edited
Loading

Just as a note, the description I believe is slightly inaccurate as tabpanel does belong to the widget abstract role https://www.w3.org/TR/wai-aria/#widget_roles There were intentional variations from spec, I learned

I'm playing with getting everything synced to the spec now to see where that gets us

gaiety-deque added a commit that referenced this issue Apr 22, 2024
@gaiety-deque
fix(aria-roles): correct abstract roles (types) for aria-roles
69f778b 
Too many aria roles were set to widget or otherwise were incorrect, added a comment source for where I got my information for which abstract roles were the type of which roles

Refs: #4371
@gaiety-deque gaiety-deque mentioned this issue Apr 22, 2024
Merged
gaiety-deque added a commit that referenced this issue Apr 25, 2024
@gaiety-deque
fix(aria-roles): address pr comments
2d185f6 
- learned sometimes we intentionally spec change
- added `window` as a supported type, and `composite` which was missing from the readme
- undid my change to `isWidgetType`

Refs: #4371
gaiety-deque added a commit that referenced this issue Apr 25, 2024
@gaiety-deque
fix(aria-roles): reverted test change as well
417e6b1 
test change was only for data tables, but we didn't want to keep that type change

Refs: #4371
gaiety-deque added a commit that referenced this issue Apr 25, 2024
@gaiety-deque
fix(aria-roles): exception for focus-order-semantics
facd65f 
add `window` to has-widget-role, renamed

Refs: #4371
gaiety-deque added a commit that referenced this issue Apr 25, 2024
@gaiety-deque
fix(aria-roles): updated locales
bfa95ae 
better pass/fail english message, removed outdated translations

Refs: #4371
gaiety-deque added a commit that referenced this issue May 2, 2024
@gaiety-deque
fix(aria-roles): correct abstract roles (types) for aria-roles (#4421)
19bde94 
Too many aria roles were set to widget or otherwise were incorrect,
added a comment source for where I got my information for which abstract
roles were the type of other aria roles

Fix: #4371
@attest-team-ci attest-team-ci mentioned this issue May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@straker straker

@gaiety-deque gaiety-deque

Labels
fix Bug fixes rules Issue or false result from an axe-core rule standards Issues in the ARIA standards objects (lib/standards) support target-size
Projects
None yet
Milestone
Axe-core 4.9.1
Development

Successfully merging a pull request may close this issue.

fix(aria-roles): correct abstract roles (types) for aria-roles dequelabs/axe-core
3 participants
@WilcoFiers @straker @gaiety-deque