Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit and Delete feature of a single tweet #65

Open
2 tasks
dappledaily opened this issue Feb 22, 2022 · 4 comments
Open
2 tasks

Edit and Delete feature of a single tweet #65

dappledaily opened this issue Feb 22, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request high priority

Comments

@dappledaily
Copy link
Collaborator

dappledaily commented Feb 22, 2022

  • Add [Edit] (pen icon) below a tweet for the author
  • Add [Share] (standard iOS share icon) below all tweets
  • Clicking Edit allows editing the tweet. When edited and reposted, the ISCN will stay same with the version number plus 1.
  • A [Delete Tweet] button is available in Edit mode. When used, a set of pre-defined words will be used as the new version of the original tweet. Also a parameter will be added to the ISCN will be added, e.g. Deleted: yes (to be discussed). depub.SPACE will not display tweets with such a parameter enabled.
  • The predefined tweet can be:

This tweet is removed from depub.SPACE frontend by the author.

  • Edit a tweet
  • Delete a tweet
@0xtaipoian
Copy link
Contributor

0xtaipoian commented May 9, 2022

@RicardDeLa please help on delete tweet first

  • update the iscn record with blank body
  • remove iscn record in durable object(graphql)

@mikasa3dom
Copy link
Collaborator

Other than updating the ISCN content to blank, should we also add a "deleted" field which says "Yes"?

@0xtaipoian
Copy link
Contributor

yes we can add deleted field into metadata, or whatever we want, boolean comparison should be more reliable and in case there if we support image only tweet in future the content might be blank.

@RicardDeLa
Copy link
Collaborator

@0xtaipoian
when call getMessage by iscn ID on graphql server,
should deleted records throw 404 error?
or throw normal message response with additional field "isDeleted"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority
Projects
None yet
Development

No branches or pull requests

4 participants