Skip to content
This repository has been archived by the owner on Mar 27, 2018. It is now read-only.

Empty line after before_script #9

Open
pragmaticivan opened this issue Dec 21, 2016 · 2 comments
Open

Empty line after before_script #9

pragmaticivan opened this issue Dec 21, 2016 · 2 comments

Comments

@pragmaticivan
Copy link
Contributor

https://github.com/metal/metal-components/blob/master/.travis.yml#L10

Seems to be inconsistent with YML format. Is that bein used? is script supposed to be inside before_script? not clear.

@fernandosouza
Copy link
Contributor

fernandosouza commented Dec 27, 2016

I'm not sure if the YAML doesn't allow it but Travis YAML file validation script displays a warning once the before_script node is empty.

Warnings for .travis.yml:
[x] value for before_script section is empty, dropping

I think the empty line is there to show that script: node isn't inside before_script.

Once before_script seems not being used I think we can remove it. I will do it and send a pull to my repo and see if everything is still working.

@pragmaticivan
Copy link
Contributor Author

I think it's there for no reason. YAML follows indentation. Let me know if that works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants