Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues and hotspots doesn't include dependency-check vulnerabilities #952

Open
arturkasperek opened this issue Jun 4, 2024 · 13 comments
Open
Labels

Comments

@arturkasperek
Copy link

Describe the bug
I'm using the following settings when running the scanner:

        -Dsonar.dependencyCheck.securityHotspot=true \
        -Dsonar.dependencyCheck.jsonReportPath=owasp-reports/dependency-check-report.json \
        -Dsonar.dependencyCheck.htmlReportPath=owasp-reports/dependency-check-report.html \
        -Dsonar.dependencyCheck.xmlReportPath=owasp-reports/dependency-check-report.xml \

I don't see any errors on SQ server or gitlabCI job dependency check logs. After all, I can see an extra item to access the report:
Zrzut ekranu 2024-06-4 o 14 42 37

It has vulnerabilities and right now don't sure why they are not included either on Issues or Security hotspots
In previous versions I saw that dependency check sonar plugin was also reporting on Issues - don't sure why it doesn't work

Versions (please complete the following information):

  • dependency-check: v9.2.0
  • sonarqube: 10.4.1.88267
  • dependency-check-sonar-plugin: 5.0.0
@Reamer
Copy link
Member

Reamer commented Jun 4, 2024

xmlReportPath is deprecated and removed.
Security Hotspot Feature is deprecated as well.

@arturkasperek
Copy link
Author

@Reamer hm - can I somehow integrate deps scan audit with sq native issues?

@Erry91
Copy link

Erry91 commented Jun 14, 2024

I am also interested in how to make vulnerabilities detections reported in the dependency-check scan appear in either "Issues" or "Security Hotspots"

@Reamer
Copy link
Member

Reamer commented Jun 14, 2024

@Reamer hm - can I somehow integrate deps scan audit with sq native issues?

Try deactivating the security hotspot feature.

@mutzbraten
Copy link

mutzbraten commented Jul 11, 2024

xmlReportPath is deprecated and removed. Security Hotspot Feature is deprecated as well.

Where do I find documentation about the deprecation of security hotspot feature?
Is there any alternative suggested?
Does this mean, the bug will not be fixed?

@Reamer
Copy link
Member

Reamer commented Aug 5, 2024

Where do I find documentation about the deprecation of security hotspot feature?

I think here: https://docs.sonarsource.com/sonarqube/latest/user-guide/security-hotspots/

Issue types (bug, vulnerability, and code smell) are deprecated

Generally speaking, I can no longer mark a rule as a security hotspot in the source code. I think therefore I can not fix this bug.

@Reamer
Copy link
Member

Reamer commented Aug 5, 2024

Checkout SonarSource/sonar-plugin-api@6785fea for more

@arturkasperek
Copy link
Author

@Reamer is there a way to integrate deps audit results on some native sonarqube view?
Right now this plugin only enables to display HTML with results. Im using sq 10.4 (in previous version it worked fine and integrated)

@Reamer
Copy link
Member

Reamer commented Aug 7, 2024

This could be possible. However, I am not a frontend developer and therefore cannot implement this requirement.

@arturkasperek
Copy link
Author

@Reamer, I don't have frontend tweaks on my mind.
Sonarqube has a native solution to register custom issues. I think with the old SQ version, issues from dependency check step were correctly registered - right now I don't see anymore any issues

@rupreck
Copy link

rupreck commented Oct 5, 2024

xmlReportPath is deprecated and removed. Security Hotspot Feature is deprecated as well.

This is a very important plugin but the change to no longer support dependency CVE's as Security Hotspots is a real disappointment. As Security Hotspots they were well presented and allowed a history of changes with notes providing traceability. As Security Issues, changes are less visible and they are not presented well. Is there any way / plan to have this capability restored? Security Hotspots are a major focus area in SonarQube.

Copy link

github-actions bot commented Dec 5, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2024
@david-vdd
Copy link

The html report is working fine, however, I'm also unable to get any indication of vulnerabilities(either issues or security hotspots) in Sonar using the latest version of sonarqube, the plugin and the dependency check.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants