-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please check contains "test" for skipTestGroups
, not starts with
#390
Comments
jeremylong
added a commit
that referenced
this issue
May 15, 2024
Sorry about the delay, I've had a ton going on outside of my OSS work. Can you take a look at #392 . Does that work for you? |
Sure, regex check is of course fine too. boolean isTestConfiguration = configuration.name =~ /((^|[a-z0-9_])T|(^|_)t)est([A-Z0-9_]|$)/ instead though. :-) |
jeremylong
added a commit
that referenced
this issue
May 15, 2024
- follow advice from @Vampire and embrace groovy - #390 (comment)
My groovy code looks so much like Java... Fixed: be04e39 |
Well, I wouldn't use Groovy for a public plugin anyway. :-D |
In hindsight I wouldn't either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the
skipTestGroups
only checks for configurations starting withandroidTest
ortest
.But this does not match things like
integTest...
,systemTest...
,functionalTest...
, ...I think for the default recognition it would be more appropriate to check for
toLowerCase().contains("test")
instead.To do something like that manually, you need some discouraged work-arounds like in the comments of #22 that reach into the models of all other projects to get all configuration names and then be able to filter on them, or list them all in the root project and hope none get added in subprojects in the future.
The text was updated successfully, but these errors were encountered: