Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires unzip #41

Closed
mxcl opened this issue Feb 6, 2023 · 3 comments
Closed

Requires unzip #41

mxcl opened this issue Feb 6, 2023 · 3 comments

Comments

@mxcl
Copy link

mxcl commented Feb 6, 2023

When running in minimal containers the action fails due to a lack of unzip, eg:

https://github.com/teaxyz/cli/actions/runs/4105361554/jobs/7082110062#step:4:8

You may feel this is “working as designed” in which case I’ll submit a PR for the README. Or perhaps you think this action should work even if unzip is not available—in which case perhaps there is a package npm or otherwise that will uncompress for us?

@kt3k
Copy link
Member

kt3k commented Feb 8, 2023

We use @actions/tool-cache for extracting zip and it depends on unzip in PATH. (They seem to have moved to system's unzip intentionally https://github.com/actions/toolkit/blob/main/packages/tool-cache/RELEASES.md#112)

I think this is by design.

cc @bartlomieju @satyarohith What do you think?

@bartlomieju
Copy link
Member

I think it's reasonable if that's the default behavior of the GH's Actions toolkit.

@lucacasonato
Copy link
Member

Yeah, this is expected behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants