Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to v1.x? #27

Open
dsherret opened this issue Feb 19, 2022 · 4 comments
Open

Default to v1.x? #27

dsherret opened this issue Feb 19, 2022 · 4 comments

Comments

@dsherret
Copy link
Member

dsherret commented Feb 19, 2022

Instead of writing:

- uses: denoland/setup-deno@v1
  with:
    deno-version: v1.x

It would be nice to write:

- uses: denoland/setup-deno@v1

Then when deno v2 is released we can bump the version of this action:

- uses: denoland/setup-deno@v2

The one risk for this is if we would want to make any breaking changes to the action, but I feel we could just do that when a new major deno version release occurs.

This would not be a breaking change because not providing a deno-version currently errors.

@satyarohith
Copy link
Member

It looks like we do have a default, but I didn't test that it works.

default: "1.x"

@dsherret
Copy link
Member Author

dsherret commented Mar 5, 2022

@satyarohith oh, I didn't realize a default was able to be set there. Do you think this would be a good versioning strategy going forward? Maybe we could add it to the readme?

@satyarohith
Copy link
Member

Do you think this would be a good versioning strategy going forward? Maybe we could add it to the readme?

I'm in favor. In addition to mentioning it in the readme, it would be nice to have a test that exercises this condition in test.yml.

@mxcl
Copy link

mxcl commented Feb 6, 2023

just to add my 2¢, I'd expect the default to be the latest stable version of deno (of any major) and the version of the action to not effect the version of deno. But perhaps I'm too experienced with actions…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants