-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to v1.x
?
#27
Comments
It looks like we do have a default, but I didn't test that it works. Line 10 in d4873ce
|
@satyarohith oh, I didn't realize a default was able to be set there. Do you think this would be a good versioning strategy going forward? Maybe we could add it to the readme? |
I'm in favor. In addition to mentioning it in the readme, it would be nice to have a test that exercises this condition in test.yml. |
just to add my 2¢, I'd expect the default to be the latest stable version of deno (of any major) and the version of the action to not effect the version of deno. But perhaps I'm too experienced with actions… |
Instead of writing:
It would be nice to write:
Then when deno v2 is released we can bump the version of this action:
The one risk for this is if we would want to make any breaking changes to the action, but I feel we could just do that when a new major deno version release occurs.
This would not be a breaking change because not providing adeno-version
currently errors.The text was updated successfully, but these errors were encountered: