-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional optional rules to consider #906
Comments
in case useful, here's a sorted list of all the rules from doing a based upon this config:
|
1000 apologies. after so... over a coupla beers... here's my shorter list of (uh) ~78 rules that me + team have found [legit] useful over last few years:
|
@traceypooh we're discussing internally providing compatibility with ESLint and ability to load ESLint plugins - this should solve your needs more generally. We could try and tackle the list you provided by implementing these rules in Rust, but there's many more plugins for specific frontend frameworks too, and I don't see us implementing all possible rules. |
OMG, that would be so sooo amazing.
So it'd be so sooo nice to get the impossibly fast :) |
@traceypooh just FYI - you can now run |
ok, this is a very interesting middle ground - thanks for the add and pointer! apologies for delay in replying -- i hadn't had the time to really drill down to figure out why my setup wasn't working. so the good news is that i have my full normal the bad news is what doesn't work (and fatals running will cause this to happen:
it doesn't matter if i reduce As a simple way to show this, one can try in an empty directory:
And you should see:
I eventually discovered this by hopefully setting up an Any thoughts? I'm wondering if there's anything that could be worked out w/ the (Lastly, if I fully comment out the |
I believe this might be caused by the fact that |
ESLint doesn’t interpret import statements in source code, it just sees an AST. From my limited experience with Deno, it seems more likely that Deno is implementing something in a typesafe way that Node.js is not. I’m not sure what eslint-module-utils You can run ESLint with If you can figure out what’s breaking, and if it’s in ESLint itself, please open an issue and we can take a look. |
@traceypooh I did some debugging and the issues seem to stem from the fact that In the concrete error you get context that is passed along, returns It's not clear to me what's the best cource of action is - on one hand |
awesome, thanks muchly for the digging @nzakas and @bartlomieju this looks potentially interesting as perhaps a way to dodge? perhaps we could write a little deno-friendly resolver that allows for local files and remote ones starting with https:// (not sure about following on to that to have it be able to parse the remote file and/or look in the deno cache)? |
Yes, writing a custom resolver would be the way to go; that said, writing resolver is easy, it's way harder to write tools that would check in Deno cache if the file exists. @kitsonk was making strides toward providing a standalone crate/JS API that could integrate with Deno's cache, but AFAIK it is not available yet. |
So for now at least, since most anything we care about at archive.org is running in docker containers these days, and mostly using GitLab CI/CD, I'm switching tactics.
here's my linter image setup & script: here's an example repo (fun lil' game :-) that uses it: When I'm doing development, all my repos are in my unix or mac $HOME dir -- so I have the same Very nice to completely cut out the remaining "weight" of node/npm in my projects. And they all get a great set of linting with just 5 easy Figured I might share, in case anyone else is in same boat, or wants to do something similar with github and github actions |
from #176
some eslint + airbnb base rules that could be nice to have w/ deno lint:
some of these I could live without -- but for example
quotes
andno-useless-concat
me and team are heavily interested in and invested in.no-plusplus
is nice esp. if you're not coding with semis -- wheresemi
is hugely useful (to flag;
where you're about to footgun - for example code right in front of a IIFE, etc.The text was updated successfully, but these errors were encountered: