You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a problem, in general, and for me personally because mastodon is a decentralized network and isn't owned by mastodon.social, and the icon will not render for a different url. This is because of the code snippet:
Which uses a regex to get the name of the social media site from the url to pass to the socialAppIcons function.
I can understand some possible reasons we want to use the url here, but couldn't we just use the title instead? I would issue a pull request but I wanted to understand the mainters' intention here before starting one.
The text was updated successfully, but these errors were encountered:
I've noticed that there is a function for rendering the icon for mastodon here:
deno_blog/components.tsx
Line 426 in 571a875
However, when I add it to the
links
as shown in the readme, for example:It's not going to render.
This is a problem, in general, and for me personally because mastodon is a decentralized network and isn't owned by mastodon.social, and the icon will not render for a different url. This is because of the code snippet:
In the source here:
deno_blog/components.tsx
Line 79 in 571a875
Which uses a regex to get the name of the social media site from the
url
to pass to thesocialAppIcons
function.I can understand some possible reasons we want to use the
url
here, but couldn't we just use thetitle
instead? I would issue a pull request but I wanted to understand the mainters' intention here before starting one.The text was updated successfully, but these errors were encountered: