Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about cf_synop_check.f90? #29

Open
pst019 opened this issue Dec 9, 2019 · 1 comment
Open

Question about cf_synop_check.f90? #29

pst019 opened this issue Dec 9, 2019 · 1 comment
Assignees
Labels
algorithm Logic of the program question Further information is requested

Comments

@pst019
Copy link
Contributor

pst019 commented Dec 9, 2019

L95 in cf_synop_check.f90 are as follows:

  if (d_cf >= d_cf_min * rkilo) then
    if (lon(i_n) > lon(i_s) .and. theta_d_cf <= pi_thirds) then
      call quadric_fit(one(1:one_num, 1:2), one_num, a, b, c, k, r2)

      if(r2 >= 0.8 .and. k <= 0.1) then
        mtype_part=1
      endif

    elseif (theta_d_cf <= pi_ninths) then
      call quadric_fit(one(1:one_num, 1:2), one_num, a, b, c, k, r2)

      if(r2 >= 0.8 .and. k<= 0.1) then
        mtype_part=1
      endif
    endif
  endif

It seems like the routine checks if the angle, theta_d_cf, is positive and below 60 degree. if this is not the case the routine checks if the angle is below 20 degree.

Is this routine detecting angles between -20 and 60 degree? Shouldn't it satisfy two (both) conditions instead of "elseif"?

@dennissergeev dennissergeev self-assigned this Dec 9, 2019
@dennissergeev
Copy link
Owner

Good question. I'll check the code and give you an update.
Thanks for reporting this.

@dennissergeev dennissergeev added algorithm Logic of the program question Further information is requested labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Logic of the program question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants