Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to dendron site show as "Private" #10

Open
chmac opened this issue Jan 18, 2022 · 1 comment
Open

Links to dendron site show as "Private" #10

chmac opened this issue Jan 18, 2022 · 1 comment

Comments

@chmac
Copy link

chmac commented Jan 18, 2022

For example here on RFC8 Multi Publish.

Under Proposal, second paragraph, there's a link:

When a user uses [[Copy Note URL|dendron://dendron.dendron-site/dendron.ref.commands#copy-note-url]], Dendron can output one of the following:

Which is shown as:

When a user uses Copy Note URL (Private), Dendron can output one of the following:

Yet that page does exist and is public, this is the url.

I'm just getting started with dendron so I'm not sure how to figure out what's going wrong and submit a PR.

@ScriptAutomate
Copy link
Contributor

This is currently due to limitations in Dendron publishing when it comes to cross-vault reference notes and publishing. The URL is marked as Private because the notes exist in the dendron.dendron-site seed/repo, on the wiki site. As a result, these are broken links for the time being.

This is currently a known issue, internally, that we are working on: resolving cross-vault notes to URLs when publishing. Otherwise, these links are currently broken due to the fact that RFCs originally existed in dendron-site, but have since been migrated.

To resolve these links, the path would be for us to either manually modify the wikilinks to be external URLs to the wiki site, or to work toward introducing wikilink-to-URL conversion upon publishing when referencing other workspaces that publish their docs.

I'm going to leave this issue open, in the meantime, as we are preferring the latter since it is a better experience within workspaces locally and on published websites. Otherwise, we'd have to update the 73 or so cross-vault links to the external link alternative, and transition them all back when the feature is supported.

> grep -irn 'dendron.dendron-site' vault/*.md
73

Once these links are working in the future, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants