Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

own email parsing, without external crate #5

Open
Simon-Laux opened this issue Oct 17, 2021 · 4 comments
Open

own email parsing, without external crate #5

Simon-Laux opened this issue Oct 17, 2021 · 4 comments

Comments

@Simon-Laux
Copy link
Member

Simon-Laux commented Oct 17, 2021

the crate we use follows specs which is good, but it is kinda big because it uses the pest parser. also it adds stuff to wasm bindgen that we might not want.

maybe we can take some testcases from them https://github.com/Sayan751/email-address-parser/tree/master/rust-lib/.test_data

@Simon-Laux
Copy link
Member Author

another reason for replacing that crate: it broke my wasm compile and exposed wasm functions without me explicitly enabling it.

@Simon-Laux
Copy link
Member Author

If the simple parsing that we have in #6 is not enough (because of false positives for example) we can do real parsing in #7

@link2xt
Copy link
Contributor

link2xt commented Sep 24, 2023

For reference, email-address-parser was removed in 839dc0f

@Simon-Laux
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants