Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

similarity_flooding case where e[1].long_name=None in __get_attribute_tuple #54

Open
cchristodoulaki opened this issue Jun 6, 2023 · 2 comments

Comments

@cchristodoulaki
Copy link

Hi Valentine authors!

I am having trouble with a bug that seems to be coming from Valentine, but I am unsure:

  • in similarity_flooding.py, is it expected that long_name may sometimes be None? (this is causing my experiments to crash)

  • dumbish question: is it possible that column_name should be =e[0].long_name ?

    def __get_attribute_tuple(self, node):
        column_name = None
        if node in self.__graph1.nodes():
            for e in self.__graph1.out_edges(node):
                links = self.__graph1.get_edge_data(e[0], e[1])
                if links.get('label') == "name":


                    column_name = e[1].long_name  ##### LONG_NAME is None
                    
                   
        else:
            for e in self.__graph2.out_edges(node):
                links = self.__graph2.get_edge_data(e[0], e[1])
                if links.get('label') == "name":
                    column_name = e[1].long_name
        return column_name
@chrisk21
Copy link
Collaborator

chrisk21 commented Jun 7, 2023

Hi Christina,

Thank you for pointing out this issue! Could you please share with us the exact error message and/or the dataset pair that creates the error? I believe it has to do with nan values on a schema level, but would greatly help to reproduce it on our side to fix it!

@cchristodoulaki
Copy link
Author

Sorry I left on extended vacation the next day :) I will post an update later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants