-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config Name Is Incorrect For Data Source In Documentation #189
Config Name Is Incorrect For Data Source In Documentation #189
Comments
hello @truly-indian , thanks for opening issue. |
@Tsovak As you mentioned you have DEKART_POSTGRES_DATA_CONNECTION to manage only data to visualize. What I am saying is that in the code where you are connecting to PG you are using the config name as DEKART_POSTGRES_DATASOURCE_CONNECTION and in the documentation you are stating the config to be used as DEKART_POSTGRES_DATA_CONNECTION which is misleading and wasting a lot of developer time. Please refer this line of code. The config name used here for pg connection is wrongly mentioned in the documentation. dekart/src/server/pgjob/pgjob.go Line 31 in 2c1ac71
|
I see. It's my mistake. it should be called DATASOURCE to keep a naming convention consistent with other parts of the project. |
the related PR opened to fix the documentation dekart-xyz/www#35 |
Great, merged doc PR, thank @Tsovak , @truly-indian |
The name of the config is incorrect in the documentation if you want to provide PG Data source. We should fix the name in the documentation.
The text was updated successfully, but these errors were encountered: