Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases nosft #104

Open
andredevjs opened this issue Apr 4, 2023 · 2 comments
Open

Releases nosft #104

andredevjs opened this issue Apr 4, 2023 · 2 comments

Comments

@andredevjs
Copy link
Contributor

andredevjs commented Apr 4, 2023

Release plan for nosft v3

Nosft v3 will be the upgraded version of our current website. And since we have a lot of different pieces, here's the plan

Home changes

Home should be modified to support the following functionality:

  • Get inscriptions and utxo's should be moved into single method should be called to get all the data we need. (This is because we are going to move later on to nosft-core this method.
  • Include the list of inscriptions for sale from nostr (Feat/live inscriptions #84)
  • On click (either on my inscriptions or the live elements), it should take the user into the inscriptions page view feat: inscriptions detail page #102 (missing click event)

Inscription details

Since it is very difficult to keep adding features in the list page, we are creating a view for it. From this view, you not only can see inscription and collection details, but also to share, boost, buy, sell, or send that inscription.
Here's what needs to be implements:

  • A single method that takes an inscription id as a parameter, and from there gets all the required information (just as listing inscriptions) to be able to view and send that inscription
  • A tab component or a different UI idea to be able to support boost, send, buy, sell, share. (@andredevjs will take care of this)
  • Since we have at this point, live ordinals from nostr and that integration we can buy and sell using also Feat/bip322 signing + PSBT signing #100, the idea here is that from that inscriptions page, if you own the utxo, you can place a sell order in nostr, by signing and sending the order through nostr. (see open order implementation)

Analytics

Nosft-core

All of this functionality, should live in nosft-core, nosft is just a client of that library, but since we have a lot of code done in nosft, we have 2 options.

  1. We move right away main to nosft-core, we keep working iterations on nosft-core, and integrate them later in nosft.
  2. We finish this plan, and then migrate everything into nosft-core.

Ideally it is easier to move main to nosft-core right away, since we are adding a ton of new functionality that might be difficult to move later.

Releases

Since this is a lot of functionality, we are going to separate releases

Release 1 (Inscription details)


The purpose of this release is to layoff the ground for the next cool features!

  1. Create a feature branch of off main, that will hold all of these features for a single release (since releasing them one by one doesn't make much sense)
  2. Add typescript support (without types or anything just the support, since most of the code is going to be moved into nosft-core which already has typescript, we just need to benefit from typescript here)
  3. Create single method to get inscriptions based on a single address parameter Get inscriptions by address #105
  4. Create a single method to get the inscription by inscription id Get inscription by inscription id #106
  5. Create a single method that based on my address and a inscription id, tells me if I own the inscription or not (maybe with the outpoint endpoint) Check if I own the inscription id #107
  6. Create view details page feat: inscriptions detail page #102
  7. Integrate send in details page

Release 🚀🚀🚀

Release 2 (Sell)


The purpose of this release is to be able to create a sell order in openOrdex to sell our inscriptions

  1. Add live view in home page Feat/live inscriptions #84 (do not allow them to go to inscription detail page YET), we are adding this view, since in this release we are supporting selling ordinals
  2. Integrate in the details page openordex and feat: inscriptions detail page #102 to be able to sell our own inscriptions, with open ordex and nostr it will create a sell order that everyone can see sign/buy

Release 🚀🚀🚀

Release 3 (Buy)


The purpose of this release is to be able to buy inscriptions from openOrdex

  1. From the live view, allow users to go to the details page, and buy the inscription
  2. Create a view all page, that shows all the inscriptions that are for sell

Release 4 (Boost)


The purpose of this release is to allow users to boost the utxo

  1. Uses nosft-core that already implements boost
  2. Add a button in nosft to boost our own inscriptions (maybe others?)

Release 🚀🚀🚀

Release 5 (Nosft-core)


The purpose of this release is to move all of the code into nosft-core, and make nosft the first nosft-core client.

  1. Move getInscriptions single method into nosft-core, and integrate that into nosft.
  2. Move getInscription by inscription id into nosft-core, and integrate that into nosft
  3. Move open ordex into nosft-core, and integrate that into nosft
  4. Move sell into nosft-core, and integrate that into nosft
  5. Move buy into nosft-core, and integrate that into nosft

Release 🚀🚀🚀

@dannydeezy
Copy link
Collaborator

I think we should put step 5 (nosft-core) before boost

@dannydeezy
Copy link
Collaborator

for the Buy step, I would like us to have a Buy-With-Lightning mechanism as well, which will require a new API endpoint on the deezy flow that i will work on. In this mechanism, the user can just pay a lightning payment and Deezy backend will handle supplying the on-chain coins and executing the purchase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants