Embedder inplace modifies input

[phiweger]

Hi,

I take this example from the OpenAIDocumentEmbedder docstring:

from haystack import Document
from haystack.components.embedders import OpenAIDocumentEmbedder

doc = Document(content="I love pizza!")
# doc.embedding is None, as I would expect

document_embedder = OpenAIDocumentEmbedder()

result = document_embedder.run([doc])
print(result['documents'][0].embedding)
# Surprising to me, doc.embedding now also holds a vector.

^ Is this intended behaviour?

Maybe it could be made more explicit like in pytorch where inplace methods carry a trailing underscore: document_embedder.run_([doc]) OR a copy.deepcopy could be added somewhere?

[lbux]

This seems to be working as intended #6107