Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EvaluationRunResult work without pandas #8793

Open
davidsbatista opened this issue Jan 31, 2025 · 0 comments · May be fixed by #8838
Open

Make EvaluationRunResult work without pandas #8793

davidsbatista opened this issue Jan 31, 2025 · 0 comments · May be fixed by #8838
Labels
Contributions wanted! Looking for external contributions good first issue Good for newcomers P3 Low priority, leave it in the backlog

Comments

@davidsbatista
Copy link
Contributor

davidsbatista commented Jan 31, 2025 •
edited by julian-risch
Loading

Refactor EvaluationRunResult to run without depending on pandas Dataframe.

  • Add an option to make the return output a .csv instead of dataframes
  • Make a LazyImport for pandas.Dataframe, which should be triggered if the functions are to output results in data frames
  • Remove the dependency on the base class BaseEvaluationRunResult
@davidsbatista davidsbatista added the Contributions wanted! Looking for external contributions label Jan 31, 2025
@davidsbatista davidsbatista added the good first issue Good for newcomers label Jan 31, 2025
@julian-risch julian-risch added the P3 Low priority, leave it in the backlog label Jan 31, 2025
@blue-gitty blue-gitty linked a pull request Feb 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contributions wanted! Looking for external contributions good first issue Good for newcomers P3 Low priority, leave it in the backlog
Projects
Haystack - Contributions wanted
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replacing Pandas in EvaluationRunResult with CustomDataFrame #8793 blue-gitty/haystack
2 participants
@julian-risch @davidsbatista